stream: port more test262 tests - #41974
Merged
nodejs-github-bot merged 1 commit intoFeb 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
reviewed
Feb 14, 2022
Comment thread
lib/internal/streams/operators.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We don't need to create a throw away object.
Suggested change
| async function some(fn, options = {}) { | |
| async function some(fn, options = undefined) { |
Sorry, something went wrong.
This was referenced Feb 15, 2022
jasnell
approved these changes
Feb 18, 2022
ronag
approved these changes
Feb 18, 2022
mcollina
approved these changes
Feb 19, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
benjamingr
force-pushed
the
add-more-test262-tests
branch
from
9644df7 to
ebc476f
Compare
February 23, 2022 10:36
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests.
benjamingr
force-pushed
the
add-more-test262-tests
branch
from
ebc476f to
c8bf95a
Compare
February 23, 2022 11:37
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41974 ✔ Done loading data for nodejs/node/pull/41974 ----------------------------------- PR info ------------------------------------ Title stream: port more test262 tests (#41974) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-more-test262-tests -> nodejs:master Labels stream, needs-ci Commits 1 - stream: port more test262 tests Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/41974 Reviewed-By: James M Snell Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41974 Reviewed-By: James M Snell Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: port more test262 tests ℹ This PR was created on Mon, 14 Feb 2022 20:47:25 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41974#pullrequestreview-887813994 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/41974#pullrequestreview-887815061 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41974#pullrequestreview-887906150 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-02-23T18:10:07Z: https://ci.nodejs.org/job/node-test-pull-request/42747/ - Querying data for job/node-test-pull-request/42747/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1889467631 |
Sorry, something went wrong.
aduh95
approved these changes
Feb 23, 2022
sxa
pushed a commit
to sxa/node
that referenced
this pull request
Mar 7, 2022
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests. PR-URL: nodejs#41974 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests. PR-URL: nodejs#41974 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Member
|
This PR can not be landed in V16.x due to a dependency with #41775 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests. PR-URL: #41974 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests. PR-URL: #41974 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests. PR-URL: nodejs/node#41974 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some test262 tests for every, add some length checks.
Turns out properties need to be writable after all according to the
test262 tests.
cc @nodejs/streams @aduh95