FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: disable empty-lines yamllint rule by Mesteery · Pull Request #42036 · nodejs/node · GitHub

/ node Public

build: disable empty-lines yamllint rule - #42036

Closed
Mesteery wants to merge 1 commit into
nodejs:mainfrom
Mesteery:disable-empty-lines
Closed

build: disable empty-lines yamllint rule#42036
Mesteery wants to merge 1 commit into
nodejs:mainfrom
Mesteery:disable-empty-lines

Conversation

Mesteery commented Feb 17, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

Do you have an example where the current setting is not a good fit?

Copy link
Copy Markdown
Contributor Author

#41981 (comment)

Copy link
Copy Markdown
Member

Thanks. Is there a reason to use multiple empty lines? I am no expert when it comes to YAML but it seems like there should be a way to avoid that.

Copy link
Copy Markdown
Contributor Author

Here is a site that can explain better than me: https://yaml-multiline.info.
In this example,

  CLOSE_MESSAGE: >
    There has been no activity on this feature request
    and it is being closed. If you feel closing this issue is not the
    right thing to do, please leave a comment.


    For more information on how the project manages
    feature requests, please consult the
    [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md).

becomes:

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

aduh95 commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

I don't think build: is the correct subsystem here – tools: would be a better fit imo.

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think we should disable the rule entirely because of a single case in which it is a false positive. If no option is added to yamllint, then we should probably just keep the yamllint disable rule:empty-lines for the few valid use cases of multiple empty lines.

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

github-actions Bot added the stale label Jul 28, 2026
avivkeller closed this Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL