FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[16.x backport] tools: enable no-empty ESLint rule by Trott · Pull Request #42160 · nodejs/node · GitHub

/ node Public

[16.x backport] tools: enable no-empty ESLint rule - #42160

Closed
Trott wants to merge 8 commits into
nodejs:v16.x-stagingfrom
Trott:v16.x-staging
ConversationCommits (8)ChecksFiles changed
Closed

[16.x backport] tools: enable no-empty ESLint rule#42160
Trott wants to merge 8 commits into
nodejs:v16.x-stagingfrom
Trott:v16.x-staging

Conversation

Trott commented Mar 1, 2022

Copy link
Copy Markdown
Member

Backport of #41831

nodejs-github-bot commented Mar 1, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
  • @nodejs/startup

Trott requested a review from danielleadams March 1, 2022 03:47
nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Mar 1, 2022
Trott mentioned this pull request Mar 1, 2022
Closed

Trott commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

The lint-md failure is unrelated, but I can add a fix for it here anyway if that's desirable. It would be this:

diff --git a/doc/api/crypto.md b/doc/api/crypto.md
index 83381cffbb..255357108c 100644
--- a/doc/api/crypto.md
+++ b/doc/api/crypto.md
@@ -2532,7 +2532,7 @@ the certificate subject is considered.
 
 If the `'subject'` option is set to `'default'`, the certificate subject is only
 considered if the subject alternative name extension either does not exist or
-does not contain any DNS names. This behavior is consistent with [RFC 2818][]
+does not contain any DNS names. This behavior is consistent with \[RFC 2818]\[]
 ("HTTP Over TLS").

ljharb commented Mar 1, 2022

Copy link
Copy Markdown
Member

@Trott it seems like that would make it be the literal text [RFC 2818][] instead of a markdown reference link defined by a [RFC 2818]: somewhere else in the document. am i misunderstanding?

Trott commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

@Trott it seems like that would make it be the literal text [RFC 2818][] instead of a markdown reference link defined by a [RFC 2818]: somewhere else in the document. am i misunderstanding?

Hmmm, I did a make format-md and copy/pasted the diff but now that I'm looking at it, yeah, that wouldn't be right. I wonder if there is a remark-ecosysytem update that needs to happen on v16.x-staging or else some other change to our lint rules or code.

danielleadams commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

@Trott @ljharb let me look into this and update the staging branch with the rest of the LTS ready commits. Hopefully, there is a fix since this didn't need to change in v17.x.

ljharb commented Mar 1, 2022

Copy link
Copy Markdown
Member

It might just be missing the link reference itself; without that present the linter might be tripping up.

danielleadams commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

@ljharb Actually - you're right. I think a commit landed that changed the docs that shouldn't have. The base branch will need to be updated. Sorry for the extra work @Trott, this'll need a rebase after.

danielleadams commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

@Trott The base branch is ready to be rebased, thanks again!

Trott added 6 commits March 2, 2022 05:21
benchmark: enable no-empty ESLint rule
bf3bb92 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
doc: remove empty block from console.timeEnd() example
a24b61a 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
doc: add comments to empty blocks in worker_threads text
7c0cd14 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
lib: add comments to empty catch statements
0038697 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
policy: revise manifest.js to avoid empty blocks
b35692f 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
stream: remove empty block
d00c97a 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Trott commented Mar 2, 2022

Copy link
Copy Markdown
Member Author

@Trott The base branch is ready to be rebased, thanks again!

OK, rebased.

Trott commented Mar 2, 2022

Copy link
Copy Markdown
Member Author

(Fixing the lint errors...)

Trott added 2 commits March 2, 2022 05:33
test: enable no-empty ESLint rule
48f5a12 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tools: enable no-empty ESLint rule
01c3818 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Trott commented Mar 2, 2022

Copy link
Copy Markdown
Member Author

OK, now it should be ready.

danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
benchmark: enable no-empty ESLint rule
1acb5cd 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
doc: remove empty block from console.timeEnd() example
b302ea1 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
doc: add comments to empty blocks in worker_threads text
1639379 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
lib: add comments to empty catch statements
7bf4fbc 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
policy: revise manifest.js to avoid empty blocks
4a75e86 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
stream: remove empty block
671dec2 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
test: enable no-empty ESLint rule
783f8ef 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
tools: enable no-empty ESLint rule
ac8537d 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
benchmark: enable no-empty ESLint rule
26205b4 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
doc: remove empty block from console.timeEnd() example
7869f85 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
doc: add comments to empty blocks in worker_threads text
17860eb 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
lib: add comments to empty catch statements
2ba99b5 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
policy: revise manifest.js to avoid empty blocks
1f37a39 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
stream: remove empty block
96cfaba 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
test: enable no-empty ESLint rule
c78168f 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
tools: enable no-empty ESLint rule
1e47815 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: #41831
Backport-PR-URL: #42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Mar 10, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
benchmark: enable no-empty ESLint rule
c4a296f 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
doc: remove empty block from console.timeEnd() example
125ed0c 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
doc: add comments to empty blocks in worker_threads text
330c1bc 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
lib: add comments to empty catch statements
acd8768 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
policy: revise manifest.js to avoid empty blocks
08b3bd2 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
stream: remove empty block
aebd82e 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
test: enable no-empty ESLint rule
c8e59cb 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
tools: enable no-empty ESLint rule
788e77c 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: #41831
Backport-PR-URL: #42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
RaisinTen RaisinTen approved these changes
+1 more reviewer
danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL