doc: make header smaller and dropdown click-driven when JS is on by ShogunPanda · Pull Request #42165 · nodejs/node · GitHub

This PR finishes the work started on #41404 by making the header small and the menu click-driver when JS is available on the browser.

Fixes: #42286

@nodejs/website

@Trott Actually I was able to enable linting for that file just by removing it from the ignore list. No issues encountered so far.

@VoltrexMaster Thanks for all your suggestions. It was the same list I got when I eslint-ed the file locally so I did it directly on my working tree.

Any update on this? Is this ready to go?

@nodejs/website @nodejs/documentation

The sticky header never shows up on screen smaller than 1000px height, I don't think it's expected, is it?

The sticky header never shows up on screen smaller than 1000px height, I don't think it's expected, is it?

It was when there was no JS. I've fixed it now. Thanks for noticing.

@aduh95 Are we good to go on this? Can I land it?

Sorry, I didn't had the occasion to pull up your branch to test the latest changes. I still have a few suggestions, but this is very close to be ready.

Landed in 0f79a27

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#42165 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#42165 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs/node#42165 Fixes: nodejs/node#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 1, 2022

VoltrexKeyva reviewed Mar 1, 2022

View reviewed changes

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

ShogunPanda force-pushed the improve-api-docs-layout-js branch from d1a018c to 4aa204e Compare March 2, 2022 13:18

aduh95 reviewed Mar 11, 2022

View reviewed changes

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

ShogunPanda force-pushed the improve-api-docs-layout-js branch from 4aa204e to e23f274 Compare March 18, 2022 11:39

aduh95 reviewed Mar 18, 2022

View reviewed changes

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

ShogunPanda force-pushed the improve-api-docs-layout-js branch from 87ee85f to cd6e683 Compare March 18, 2022 16:59

aduh95 reviewed Mar 18, 2022

View reviewed changes

Comment thread doc/template.html Outdated

aduh95 reviewed Mar 21, 2022

View reviewed changes

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

Comment thread doc/api_assets/api.js Outdated

ShogunPanda added 6 commits March 22, 2022 07:57

doc: make header smaller and dropdown click-driven when JS is on

770215f

doc: add assets JS to the linting list

e94673a

doc: refactored api script

3eae4bc

doc: defer script loading

d785152

doc: defer script loading

05c4fad

doc: ensure scope to api assets

5e2d376

ShogunPanda force-pushed the improve-api-docs-layout-js branch from 60f14ba to 5e2d376 Compare March 22, 2022 06:58

doc: linted code

72a2aef

aduh95 approved these changes Mar 22, 2022

View reviewed changes

aymen94 approved these changes Mar 22, 2022

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2022

nodejs-github-bot merged commit 0f79a27 into nodejs:master Mar 22, 2022

ShogunPanda deleted the improve-api-docs-layout-js branch March 23, 2022 06:48

juanarbol pushed a commit that referenced this pull request Apr 4, 2022

doc: make header smaller and dropdown click-driven when JS is on

c89ed0c

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022

doc: make header smaller and dropdown click-driven when JS is on

89da27c

PR-URL: nodejs#42165 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This was referenced Apr 5, 2022

V17.8.1 proposal #42612

Closed

v17.9.0 proposal #42613

Merged

juanarbol pushed a commit that referenced this pull request Apr 6, 2022

doc: make header smaller and dropdown click-driven when JS is on

00f693b

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022

doc: make header smaller and dropdown click-driven when JS is on

a7b9085

PR-URL: nodejs#42165 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

juanarbol pushed a commit that referenced this pull request May 31, 2022

doc: make header smaller and dropdown click-driven when JS is on

54720f5

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

danielleadams pushed a commit that referenced this pull request Jun 27, 2022

doc: make header smaller and dropdown click-driven when JS is on

2048082

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Jul 11, 2022

doc: make header smaller and dropdown click-driven when JS is on

5b5295f

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Jul 31, 2022

doc: make header smaller and dropdown click-driven when JS is on

d9ae6c7

PR-URL: #42165 Fixes: #42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022

doc: make header smaller and dropdown click-driven when JS is on

e820a08

PR-URL: nodejs/node#42165 Fixes: nodejs/node#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc: make header smaller and dropdown click-driven when JS is on by ShogunPanda · Pull Request #42165 · nodejs/node · GitHub

Uh oh!

Uh oh!

doc: make header smaller and dropdown click-driven when JS is on - #42165

doc: make header smaller and dropdown click-driven when JS is on#42165nodejs-github-bot merged 7 commits intonodejs:masternodejs/node:masterfrom ShogunPanda:improve-api-docs-layout-jsShogunPanda/node:improve-api-docs-layout-jsCopy head branch name to clipboard

Conversation

ShogunPanda commented Mar 1, 2022 • edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Mar 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShogunPanda commented Mar 2, 2022

Uh oh!

ShogunPanda commented Mar 4, 2022

Uh oh!

Trott commented Mar 4, 2022

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShogunPanda commented Mar 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShogunPanda commented Mar 21, 2022

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

doc: make header smaller and dropdown click-driven when JS is on#42165
nodejs-github-bot merged 7 commits into
nodejs:masterfrom
ShogunPanda:improve-api-docs-layout-js

ShogunPanda commented Mar 1, 2022 •
edited by aduh95
Loading