FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[16.x] build: remove windows-2022 from v16.x actions by danielleadams · Pull Request #42299 · nodejs/node · GitHub

/ node Public

[16.x] build: remove windows-2022 from v16.x actions - #42299

Closed
danielleadams wants to merge 1 commit into
nodejs:v16.x-stagingfrom
danielleadams:remove-windows-2022
ConversationCommits (1)ChecksFiles changed
Closed

[16.x] build: remove windows-2022 from v16.x actions#42299
danielleadams wants to merge 1 commit into
nodejs:v16.x-stagingfrom
danielleadams:remove-windows-2022

Conversation

danielleadams commented Mar 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removes GitHub actions run on the windows-2022 virtual environment for v16.x release line. (As mentioned here: #42200) (cc @nodejs/releasers, @gengjiawen)

nodejs-github-bot commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v16.x labels Mar 11, 2022
gengjiawen reviewed Mar 11, 2022
View reviewed changes
Comment thread BUILDING.md Outdated
danielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2022

github-actions Bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

danielleadams commented Mar 11, 2022

Copy link
Copy Markdown
Contributor Author

Landed in 728b657

danielleadams deleted the remove-windows-2022 branch March 11, 2022 17:01
danielleadams added a commit that referenced this pull request Mar 11, 2022
build: remove windows-2022 from v16.x actions
728b657 
PR-URL: #42299
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Mar 11, 2022
Merged

BethGriggs commented Mar 11, 2022

Copy link
Copy Markdown
Member

Belated +1 to this PR and unblocking the release.

It looks like windows-2022 has been in the matrix for Node.js 16 since 6775958 (Sept 2021) - so it was presumably passing on this configuration up until the recent actions update (actions/runner-images@c0d5701, mentioned in #42200 (comment))?

I am just wondering if we should open an issue to track/identify this problem? I could see the outcome potentially being that we can add it back when/if a future actions update fixes it? Or maybe opt to update BUILDING.md as I think(?) it is implicitly stating that this would be a supported toolchain for Node.js 16?

gengjiawen commented Mar 12, 2022

Copy link
Copy Markdown
Member

I am just wondering if we should open an issue to track/identify this problem?

Sure. I also tried to report the bug to MSVC team yesterday, but report bug entrance only in visual studio on windows which I don't have for now.

danielleadams added a commit that referenced this pull request Mar 14, 2022
build: remove windows-2022 from v16.x actions
79e2ab2 
PR-URL: #42299
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

euphy-wong commented Mar 16, 2022

Copy link
Copy Markdown

I am just wondering if we should open an issue to track/identify this problem?

Sure. I also tried to report the bug to MSVC team yesterday, but report bug entrance only in visual studio on windows which I don't have for now.

I've already reported this bug to MSVC team issue ticket

gengjiawen mentioned this pull request Apr 1, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
Trott Trott approved these changes
richardlau richardlau approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL