doc: expand history for conditional exports changes in v12 - #42339
Merged
nodejs-github-bot merged 2 commits intoMar 26, 2022
Merged
doc: expand history for conditional exports changes in v12#42339nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM, thanks |
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Mar 15, 2022
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Based on the previous discussions I presume the info is accurate, so LGTM
Sorry, something went wrong.
GeoffreyBooth
approved these changes
Mar 15, 2022
jasnell
approved these changes
Mar 25, 2022
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
Fixes: nodejs#36162 PR-URL: nodejs#42339 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Fixes: nodejs#36162 PR-URL: nodejs#42339 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Fixes: nodejs/node#36162 PR-URL: nodejs/node#42339 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #42336 this change adds some extra detail to the history of unflagging conditional exports across v12.16 and v2.17. In v13 conditional exports became fully unflagged in v13.7 when --experimental-conditional-exports was removed.
Unfortunately the version order linting rule doesn't allow putting the removal of --experimental-modules for just 12.17.0 above the removal of --experimental-conditional-exports in both 12.16.0 and 13.7.0, but hopefully the change there is still clear.
Fixes: #36162