tools: fix skip PR if CI is still running - #42377
Merged
nodejs-github-bot merged 2 commits intoMar 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
reviewed
Mar 17, 2022
Comment thread
tools/actions/commit-queue.sh
Outdated
Copy link
Copy Markdown
Contributor
ncu-ci output can be greped AFAICT. I think the problem comes from the fact that ncu-ci only checks Jenkins CI, not GitHub Actions ones. I agree that using GitHub CLI should do the trick as it's effectively checking both. |
Sorry, something went wrong.
aduh95
reviewed
Mar 17, 2022
Comment thread
meixg
Outdated
change according to review
aduh95
approved these changes
Mar 17, 2022
mhdawson
approved these changes
Mar 18, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Mesteery
approved these changes
Mar 19, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
resolve: nodejs#40330 PR-URL: nodejs#42377 Fixes: nodejs#40330 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
resolve: nodejs#40330 PR-URL: nodejs#42377 Fixes: nodejs#40330 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
resolve: nodejs/node#40330 PR-URL: nodejs/node#42377 Fixes: nodejs/node#40330 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original "Skip PR if CI is still running" seems not working, I find it is because ncu-ci url's output can't be greped (not totally sure because I don't have access to jenkins).
Using gh pr checks should be just fine I guess.
Fixes: #40330