FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v17.7.2 proposal by richardlau · Pull Request #42381 · nodejs/node · GitHub

/ node Public

v17.7.2 proposal - #42381

Merged
richardlau merged 5 commits into
v17.xfrom
v17.7.2-proposal
Mar 18, 2022
ConversationCommits (5)ChecksFiles changed
Merged

v17.7.2 proposal#42381
richardlau merged 5 commits into
v17.xfrom
v17.7.2-proposal

Conversation

richardlau commented Mar 17, 2022

Copy link
Copy Markdown
Member

A combination of some GitHub issues today and having to take over this release at short notice has resulted in my decision to only pick the OpenSSL commits over for this proposal instead of our usual "treat current as a regular release". This should hopefully reduce the risk and give us more chance of getting the release out today. cc @nodejs/releasers

2022-03-17, Version 17.7.2 (Current), @richardlau

This is a security release.

Notable Changes

Update to OpenSSL 3.0.2, which addresses the following vulnerability:

Commits

  • [55e293e05f] - deps: update archs files for quictls/openssl-3.0.2+quic (Hassaan Pasha) #42356
  • [b8d090603d] - deps: upgrade openssl sources to quictls/openssl-3.0.2+quic (Hassaan Pasha) #42356
  • [c8b6d92af0] - test: fix tests affected by OpenSSL update (Michael Dawson) #42356
  • [457e31ea09] - test: renew certificates for specific test (Luigi Pinca) #42342

lpinca and others added 5 commits March 17, 2022 12:25
test: renew certificates for specific test
457e31e 
Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.

PR-URL: #42342
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
deps: upgrade openssl sources to quictls/openssl-3.0.2+quic
b8d0906 
This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl

PR-URL: #42356
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-March/000217.html
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
deps: update archs files for quictls/openssl-3.0.2+quic
55e293e 
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit

PR-URL: #42356
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-March/000217.html
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
test: fix tests affected by OpenSSL update
c8b6d92 
Last OpenSSL 3 update changes behaviour back to be
closer to that of OpenSSL 1.1.1. Remove some instances
where we expected different errors from OpenSSL 3 versus
OpenSSL 1.1.1.

Signed-off-by: Michael Dawson <midawson@redhat.com>

PR-URL: #42356
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-March/000217.html
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-03-17, Version 17.7.2 (Current)
db3d882 
This is a security release.

Notable changes:

Update to OpenSSL 3.0.2, which addresses the following vulnerability:
- Infinite loop in BN_mod_sqrt() reachable when parsing certificates (High)(CVE-2022-0778)
  More details are available at https://www.openssl.org/news/secadv/20220315.txt

PR-URL: #42381
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2022
nodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v17.x labels Mar 17, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2022

nodejs-github-bot commented Mar 17, 2022 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43095/
Release build on db3d882: https://ci-release.nodejs.org/job/iojs+release/8324/
rebuild of failing osx11-release-pkg: https://ci-release.nodejs.org/job/iojs+release/8325/

mhdawson approved these changes Mar 17, 2022
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43097/

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43100/

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43102/

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43103/

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43106/

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43107/

richardlau added a commit that referenced this pull request Mar 18, 2022
Working on v17.7.3
38fb0e5 
PR-URL: #42381
richardlau merged commit db3d882 into v17.x Mar 18, 2022
richardlau added a commit that referenced this pull request Mar 18, 2022
2022-03-17, Version 17.7.2 (Current)
a66b9ca 
This is a security release.

Notable changes:

Update to OpenSSL 3.0.2, which addresses the following vulnerability:
- Infinite loop in BN_mod_sqrt() reachable when parsing certificates (High)(CVE-2022-0778)
  More details are available at https://www.openssl.org/news/secadv/20220315.txt

PR-URL: #42381
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Mar 18, 2022
Blog: v17.7.2 release post
bf56583 
Refs: nodejs/node#42381
aduh95 deleted the v17.7.2-proposal branch March 18, 2022 01:25
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Mar 18, 2022
Blog: v17.7.2 release post
6458948 
Refs: nodejs/node#42381
richardlau mentioned this pull request Mar 18, 2022
Merged
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Mar 18, 2022
Blog: v17.7.2 release post (#4501)
11a14c0 
Refs: nodejs/node#42381
This was referenced Mar 22, 2022
Open
Open
Open
Open
Open
Open
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
2022-03-17, Version 17.7.2 (Current)
d6bc18a 
This is a security release.

Notable changes:

Update to OpenSSL 3.0.2, which addresses the following vulnerability:
- Infinite loop in BN_mod_sqrt() reachable when parsing certificates (High)(CVE-2022-0778)
  More details are available at https://www.openssl.org/news/secadv/20220315.txt

PR-URL: nodejs#42381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL