net,dns: trace tcp connection and dns by perf_hooks by theanarkh · Pull Request #42390 · nodejs/node · GitHub

use the perf_hooks to trace the time spent by net.connect, dns.lookup,
dns.lookupService, dns.resolvexxx.

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s): net, dns

Review requested:

@nodejs/net

lgtm

LGTM!

CI: https://ci.nodejs.org/job/node-test-pull-request/43129/

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx.

Is this PR ok or is there anything I need to do？

CI: https://ci.nodejs.org/job/node-test-pull-request/43181/

CI: https://ci.nodejs.org/job/node-test-pull-request/43182/

@mcollina hello, Is this PR ok or is there anything I need to do？thanks.

This can land!

Commit Queue failed

- Loading data for nodejs/node/pull/42390
✔  Done loading data for nodejs/node/pull/42390
----------------------------------- PR info ------------------------------------
Title      net,dns: trace tcp connection and dns by perf_hooks (#42390)
Author     theanarkh  (@theanarkh, first-time contributor)
Branch     theanarkh:trace_net_and_dns_by_perf_hooks -> nodejs:master
Labels     lib / src, author ready
Commits    1
 - net,dns: trace tcp connection and dns by perf_hooks
Committers 1
 - theanarkh <2923878201@qq.com>
PR-URL: https://github.com/nodejs/node/pull/42390
Reviewed-By: Matteo Collina 
Reviewed-By: Paolo Insogna 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42390
Reviewed-By: Matteo Collina 
Reviewed-By: Paolo Insogna 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - net,dns: trace tcp connection and dns by perf_hooks
   ℹ  This PR was created on Fri, 18 Mar 2022 13:13:33 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42390#pullrequestreview-914468480
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/42390#pullrequestreview-914493022
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42390#pullrequestreview-915032295
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-03-24T09:18:30Z: https://ci.nodejs.org/job/node-test-pull-request/43182/
- Querying data for job/node-test-pull-request/43182/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2059520015

lgtm

Landed in e520039

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: #42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: nodejs#42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: #42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: nodejs#42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: #42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: nodejs/node#42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 18, 2022

mcollina approved these changes Mar 18, 2022

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2022

This comment was marked as outdated.

Sign in to view

theanarkh force-pushed the trace_net_and_dns_by_perf_hooks branch 2 times, most recently from 3508c15 to d63fe2b Compare March 18, 2022 15:05

ShogunPanda approved these changes Mar 18, 2022

View reviewed changes

theanarkh force-pushed the trace_net_and_dns_by_perf_hooks branch from d63fe2b to edff14f Compare March 18, 2022 15:31

VoltrexKeyva reviewed Mar 18, 2022

View reviewed changes

Comment thread doc/api/perf_hooks.md Outdated

Comment thread doc/api/perf_hooks.md Outdated

Comment thread doc/api/perf_hooks.md Outdated

theanarkh force-pushed the trace_net_and_dns_by_perf_hooks branch 2 times, most recently from ec85f61 to c7213e4 Compare March 18, 2022 17:47

github-actions Bot mentioned this pull request Mar 19, 2022

CI Reliability 2022-03-19 nodejs/reliability#225

Open

37 tasks

This comment was marked as outdated.

Sign in to view

theanarkh force-pushed the trace_net_and_dns_by_perf_hooks branch from c7213e4 to 98d4677 Compare March 19, 2022 09:40

VoltrexKeyva approved these changes Mar 19, 2022

View reviewed changes

VoltrexKeyva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 19, 2022

This was referenced Mar 20, 2022

CI Reliability 2022-03-20 nodejs/reliability#226

Open

CI Reliability 2022-03-21 nodejs/reliability#227

Open

theanarkh force-pushed the trace_net_and_dns_by_perf_hooks branch from 98d4677 to 9d395b7 Compare March 21, 2022 13:34

github-actions Bot mentioned this pull request Mar 22, 2022

CI Reliability 2022-03-22 nodejs/reliability#228

Open

32 tasks

net,dns: trace tcp connection and dns by perf_hooks

62b33bb

use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx.

theanarkh force-pushed the trace_net_and_dns_by_perf_hooks branch from 9d395b7 to 62b33bb Compare March 23, 2022 05:24

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 29, 2022

mcollina approved these changes Mar 29, 2022

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 29, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2022

nodejs-github-bot merged commit e520039 into nodejs:master Mar 29, 2022

This was referenced Apr 5, 2022

V17.8.1 proposal #42612

Closed

v17.9.0 proposal #42613

Merged

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

net,dns: trace tcp connection and dns by perf_hooks by theanarkh · Pull Request #42390 · nodejs/node · GitHub

Uh oh!

Uh oh!

net,dns: trace tcp connection and dns by perf_hooks - #42390

net,dns: trace tcp connection and dns by perf_hooks#42390nodejs-github-bot merged 1 commit intonodejs:masternodejs/node:masterfrom theanarkh:trace_net_and_dns_by_perf_hookstheanarkh/node:trace_net_and_dns_by_perf_hooksCopy head branch name to clipboard

Conversation

theanarkh commented Mar 18, 2022

Uh oh!

nodejs-github-bot commented Mar 18, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

ShogunPanda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Mar 19, 2022

Uh oh!

theanarkh commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 24, 2022

Uh oh!

nodejs-github-bot commented Mar 24, 2022

Uh oh!

theanarkh commented Mar 28, 2022

Uh oh!

mcollina commented Mar 29, 2022

Uh oh!

nodejs-github-bot commented Mar 29, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

net,dns: trace tcp connection and dns by perf_hooks#42390
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
theanarkh:trace_net_and_dns_by_perf_hooks

theanarkh commented Mar 23, 2022 •
edited
Loading