FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update property name by Trott · Pull Request #42398 · nodejs/node · GitHub

/ node Public

doc: update property name - #42398

Merged
nodejs-github-bot merged 1 commit into
masterfrom
Trott-patch-1
Mar 21, 2022
ConversationCommits (1)ChecksFiles changed
Merged

doc: update property name#42398
nodejs-github-bot merged 1 commit into
masterfrom
Trott-patch-1

Conversation

Trott commented Mar 19, 2022

Copy link
Copy Markdown
Member

Property name min was updated in 23637e9
to lowest but an instance of min was missed.

doc: update property name
cacca4a 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.
Trott requested a review from jasnell March 19, 2022 02:07
nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Mar 19, 2022
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 19, 2022
Bilalssbb reviewed Mar 19, 2022
View reviewed changes

Bilalssbb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

doc: update property name

Bilalssbb reviewed Mar 19, 2022
View reviewed changes

Bilalssbb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

doc: update property name

Trott commented Mar 19, 2022

Copy link
Copy Markdown
Member Author

doc: update property name

User blocked.

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2022
nodejs-github-bot merged commit 4e2fefc into master Mar 21, 2022

nodejs-github-bot commented Mar 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4e2fefc

Trott deleted the Trott-patch-1 branch March 21, 2022 05:29
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
doc: update property name
056ae57 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
doc: update property name
07b38f6 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
doc: update property name
10d638a 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
doc: update property name
8a534be 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
doc: update property name
a197ad9 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
doc: update property name
516a40d 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
doc: update property name
ae764ae 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
doc: update property name
165ee28 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
doc: update property name
c4f3729 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs/node#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
HarshithaKP HarshithaKP approved these changes
jasnell Awaiting requested review from jasnell
+2 more reviewers
Bilalssbb Bilalssbb left review comments
Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL