doc: standardize typography for _semantic versioning_ - #42401
Merged
nodejs-github-bot merged 1 commit intoMar 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tniessen
approved these changes
Mar 19, 2022
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This seems to align with npm even though semver itself seems to capitalize both words.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Yes, and it also aligns with Wikipedia. It's an interesting one because with products, companies, and organizations, we would follow suit with how the company or organization styles it. But protocols and procedures seem more of a grey area. |
Sorry, something went wrong.
lpinca
approved these changes
Mar 19, 2022
Mesteery
approved these changes
Mar 20, 2022
marsonya
approved these changes
Mar 21, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42401 ✔ Done loading data for nodejs/node/pull/42401 ----------------------------------- PR info ------------------------------------ Title doc: standardize typography for _semantic versioning_ (#42401) Author Rich Trott (@Trott) Branch Trott:semver -> nodejs:master Labels doc, author ready Commits 1 - doc: standardize typography for _semantic versioning_ Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/42401 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mestery Reviewed-By: Akhil Marsonya ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42401 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mestery Reviewed-By: Akhil Marsonya -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 19 Mar 2022 16:24:45 GMT ✔ Approvals: 4 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42401#pullrequestreview-915016593 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42401#pullrequestreview-915032712 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42401#pullrequestreview-915046390 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42401#pullrequestreview-915396601 ✖ This PR needs to wait 6 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2015323653 |
Sorry, something went wrong.
RaisinTen
approved these changes
Mar 21, 2022
juanarbol
pushed a commit
that referenced
this pull request
Apr 4, 2022
PR-URL: #42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42401 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.