async_hooks: remove destroyed symbol on Promises - #42402
Merged
nodejs-github-bot merged 1 commit intoMar 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already.
Flarna
force-pushed
the
rm_promise_destroyed
branch
from
9755d16 to
50a82b7
Compare
March 19, 2022 17:36
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Mar 19, 2022
VoltrexKeyva
approved these changes
Mar 19, 2022
juanarbol
pushed a commit
that referenced
this pull request
Apr 4, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: #42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: nodejs#42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: #42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: nodejs#42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: #42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: #42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: #42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: #42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already. PR-URL: nodejs/node#42402 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promises are never destroyed manually therefore it's not needed to attach an object to track if destroy hook was called already.
Refs: #42229 (comment)