FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: fix misc/startup failure by mscdex · Pull Request #42442 · nodejs/node · GitHub

/ node Public

benchmark: fix misc/startup failure - #42442

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:benchmark-fix-misc-startup-failure
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: fix misc/startup failure#42442
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:benchmark-fix-misc-startup-failure

Conversation

mscdex commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

Fixes: #42437

It's not the ideal fix as it's duplicating a list/Set that already exists in the internals but 🤷‍♂️

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Mar 23, 2022

mscdex commented Mar 23, 2022

Copy link
Copy Markdown
Contributor Author

Benchmark run for misc/startup

nodejs-github-bot commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43175/

Trott requested a review from cjihrig March 23, 2022 04:22

cjihrig commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

I would hold off on landing this because whether or not we are keeping node:test is under discussion in #42430.

This was referenced Mar 24, 2022
Open
Open
This was referenced Mar 26, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 2, 2022
Open
Open

mscdex commented Apr 12, 2022

Copy link
Copy Markdown
Contributor Author

@cjihrig Since the discussion in #42430 seems to be (presumably) taking longer than expected, can we merge this in the meantime? It's no longer just affecting my daily benchmark runs, but now also PRs that need to run the benchmark.

cjihrig commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Yea, I think it's probably fine to merge. Sorry for the hold up.

aduh95 reviewed Apr 12, 2022
View reviewed changes
Comment thread benchmark/fixtures/require-cachable.js
for (let key of canBeRequired) {
if (modulesNeedingPrefix.includes(key))
key = `node:${key}`;
require(key);

aduh95 Apr 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any reason not to use the prefix for all modules?

Suggested change
require(key);
require(`node:${key}`);

aduh95 mentioned this pull request Apr 15, 2022
Merged

aduh95 commented Apr 17, 2022

Copy link
Copy Markdown
Contributor

Closing because #42746 has landed, and fixes the issue. Please re-open if I'm mistaken.

aduh95 closed this Apr 17, 2022
mscdex deleted the benchmark-fix-misc-startup-failure branch April 17, 2022 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
cjihrig Awaiting requested review from cjihrig

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

misc/startup benchmark broken as of 3c4ee52

6 participants

Back | FazBrowse Home | New Git URL