doc: add suggestion for OpenSSL only sec releases - #42456
Closed
mhdawson wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RaisinTen
reviewed
Mar 24, 2022
Comment thread
doc/contributing/security-release-process.md
Outdated
Co-authored-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
approved these changes
Mar 24, 2022
Copy link
Copy Markdown
Member
|
Doesn't the same apply to other dependencies like libuv, nghttp2 etc? |
Sorry, something went wrong.
jasnell
approved these changes
Mar 25, 2022
Copy link
Copy Markdown
Member
Author
That may be true, but it seems like the most common case of a security release only affection one is OpenSSL. |
Sorry, something went wrong.
danielleadams
approved these changes
Mar 30, 2022
tniessen
approved these changes
Mar 31, 2022
mhdawson
added a commit
that referenced
this pull request
Mar 31, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Fixes: nodejs/TSC#1187 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#42456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/TSC#1187
Signed-off-by: Michael Dawson mdawson@devrus.com