doc: remove extraneous comma - #42548
Conversation
Sorry, something went wrong.
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
| on a unique port, generate a port number based on the cluster worker ID. | ||
|
|
||
| Node.js does not provide routing logic. It is, therefore important to design an | ||
| Node.js does not provide routing logic. It is therefore important to design an |
There was a problem hiding this comment.
| Node.js does not provide routing logic. It is therefore important to design an | |
| Node.js does not provide routing logic. It is, therefore, important to design an |
Sorry, something went wrong.
There was a problem hiding this comment.
That would work too but I think it's better without the commas. I will do it that way if you have a strong preference though. As long as there are either two commas or zero commas, I'm good. One comma is Not OK.
Sorry, something went wrong.
There was a problem hiding this comment.
is therefore even necessary language here? Feels like a flourish that can potentially be just dropped.
Sorry, something went wrong.
There was a problem hiding this comment.
Honestly, I was just looking for the smallest possible change to fix the issue in the text, so adding a comma or removing a comma were the options I considered. The word therefore is perhaps not necessary, but I think it is valuable as a cue that the recommendation in this sentence is due to the condition explained in the previous sentence. That said, I'm OK with removing it if that's the consensus.
Sorry, something went wrong.
There was a problem hiding this comment.
But uh...I see this has sufficient approvals as is, so I'm going to land before we bikeshed any further. 😀
Sorry, something went wrong.
PR-URL: nodejs#42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: nodejs#42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: nodejs/node#42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
No description provided.