FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: do not add undefined hash in webcrypto normalizeAlgorithm by panva · Pull Request #42559 · nodejs/node · GitHub

/ node Public

crypto: do not add undefined hash in webcrypto normalizeAlgorithm - #42559

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
panva:fix-undefined-hash-from-normalize
Apr 3, 2022
ConversationCommits (2)ChecksFiles changed
Merged

crypto: do not add undefined hash in webcrypto normalizeAlgorithm#42559
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
panva:fix-undefined-hash-from-normalize

Conversation

panva commented Apr 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Every now and then, when working with node's WebCryptoAPI, I noticed that the key's algorithm had an undefined hash property that wasn't present at the time of importing/deriving/generating. This, while not affecting the functionality of webcrypto, is not expected. This PR fixes that.

panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Apr 1, 2022

nodejs-github-bot commented Apr 1, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 1, 2022

tniessen commented Apr 1, 2022

Copy link
Copy Markdown
Member

Looks like there are some related failures, could you take a look, please?

panva commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

Looks like there are some related failures, could you take a look, please?

Yeah i'm trying to figure out how to best debug wpt failures right now.

panva marked this pull request as draft April 1, 2022 16:07
panva force-pushed the fix-undefined-hash-from-normalize branch from b09d864 to df21856 Compare April 1, 2022 16:45
nodejs deleted a comment from nodejs-github-bot Apr 1, 2022
panva marked this pull request as ready for review April 1, 2022 16:46
nodejs deleted a comment from nodejs-github-bot Apr 1, 2022
panva force-pushed the fix-undefined-hash-from-normalize branch from df21856 to 379b548 Compare April 1, 2022 16:48

nodejs-github-bot commented Apr 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43259/

panva removed the needs-ci PRs that need a full CI run. label Apr 1, 2022

nodejs-github-bot commented Apr 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43260/

github-actions Bot mentioned this pull request Apr 2, 2022
Open
9 tasks
Trott added the needs-ci PRs that need a full CI run. label Apr 2, 2022

Trott commented Apr 2, 2022

Copy link
Copy Markdown
Member

A bit of an aside, but I've re-added the needs-ci label.

It's perhaps a bit confusingly named, but the needs-ci label is there for the commit queue automation. It tells the automation that this is a PR that should land only if there is a passing Jenkins CI run. It's not a label letting other people know that we need a CI run. So it should generally not be manually removed (unless it was incorrectly placed on a PR in the first place.)

Refs: https://github.com/nodejs/node-core-utils/blob/919ec3b784a2589aa88a1b2629b98d57283555a4/lib/pr_checker.js#L431-L438

panva added experimental Issues and PRs related to experimental features. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Apr 2, 2022
tniessen approved these changes Apr 2, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tiny nit: since the file being test is called util.js, consider renaming the test to test-webcrypto-util.js (instead of test-webcrypto-utils.js).

Comment thread test/parallel/test-webcrypto-utils.js Outdated
Comment thread test/parallel/test-webcrypto-utils.js Outdated
Comment thread lib/internal/crypto/util.js Outdated

nodejs-github-bot commented Apr 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43266/

tniessen approved these changes Apr 2, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for updating :)

github-actions Bot mentioned this pull request Apr 3, 2022
Open
8 tasks
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2022
nodejs-github-bot merged commit 5d0eb10 into nodejs:master Apr 3, 2022

nodejs-github-bot commented Apr 3, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5d0eb10

panva deleted the fix-undefined-hash-from-normalize branch April 3, 2022 10:11
This was referenced Apr 4, 2022
Open
Open
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
fa7edb7 
PR-URL: nodejs#42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Apr 5, 2022
Closed
Merged
github-actions Bot mentioned this pull request Apr 6, 2022
Open
11 tasks
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
a2f0738 
PR-URL: #42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
github-actions Bot mentioned this pull request Apr 7, 2022
Open
17 tasks
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
256ca2e 
PR-URL: nodejs#42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol pushed a commit that referenced this pull request May 31, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
fd3a8bf 
PR-URL: #42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
963d7e0 
PR-URL: #42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 11, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
e11e161 
PR-URL: #42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
297e374 
PR-URL: #42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
2f0d80b 
PR-URL: nodejs/node#42559
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL