FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: aes webcrypto unwrap is not a node-specific extensions by panva · Pull Request #42561 · nodejs/node · GitHub

/ node Public

doc: aes webcrypto unwrap is not a node-specific extensions - #42561

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
panva:doc-fix-webcrypto
Apr 3, 2022
Merged

doc: aes webcrypto unwrap is not a node-specific extensions#42561
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
panva:doc-fix-webcrypto

Conversation

panva commented Apr 1, 2022

Copy link
Copy Markdown
Member

'AES-CTR', 'AES-CBC', 'AES-GCM', and 'AES-KW' are regular SubtleCrypto.unwrapKey algorithm, not node-specific extensions

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 1, 2022
panva added the webcrypto label Apr 1, 2022
panva requested a review from jasnell April 1, 2022 10:19

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Am I correct to assume that this is because of this step in unwrapKey?

If an error occurred, let normalizedAlgorithm be the result of normalizing an algorithm, with alg set to algorithm and op set to "decrypt".

panva commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

Am I correct to assume that this is because of this step in unwrapKey?

If an error occurred, let normalizedAlgorithm be the result of normalizing an algorithm, with alg set to algorithm and op set to "decrypt".

Yeah, that's the beginning of it.

https://w3c.github.io/webcrypto/#SubtleCrypto-method-unwrapKey

If an error occurred, let normalizedAlgorithm be the result of normalizing an algorithm, with alg set to algorithm and op set to "decrypt".

which then leads to

Otherwise, if normalizedAlgorithm supports a decrypt operation:
Let key be the result of performing the decrypt operation specified by normalizedAlgorithm using algorithm, unwrappingKey as key and wrappedKey as ciphertext.

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 1, 2022
panva added experimental Issues and PRs related to experimental features. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 2, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2022
nodejs-github-bot merged commit e12cfd8 into nodejs:master Apr 3, 2022

Copy link
Copy Markdown
Collaborator

Landed in e12cfd8

panva deleted the doc-fix-webcrypto branch April 3, 2022 10:11
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
PR-URL: nodejs#42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Apr 5, 2022
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL