test: allow numeric string for lookupService test - #42596
Merged
nodejs-github-bot merged 2 commits intoApr 12, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes: nodejs#42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number.
daeyeon
force-pushed
the
master.test-220404.Mon.009f
branch
from
385fd01 to
3031525
Compare
April 4, 2022 00:35
VoltrexKeyva
reviewed
Apr 4, 2022
Comment thread
test/parallel/test-dns-lookupService-promises.js
Outdated
daeyeon
force-pushed
the
master.test-220404.Mon.009f
branch
from
d7f03e6 to
4d4292d
Compare
April 4, 2022 13:59
VoltrexKeyva
approved these changes
Apr 6, 2022
marsonya
approved these changes
Apr 9, 2022
This comment was marked as outdated.
This was referenced Apr 10, 2022
Copy link
Copy Markdown
Member
Author
|
I think the Jenkins CI failures are unrelated to the change in this PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Jenkins CI tests tend to be flaky or timeout, I've restarted them for you. |
Sorry, something went wrong.
29 tasks
Copy link
Copy Markdown
Member
Author
|
There are still Jenkins CI failures seemingly unrelated to this PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Apr 12, 2022
25 tasks
24 tasks
This was referenced Apr 15, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Fixes: nodejs#42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number. PR-URL: nodejs#42596 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Fixes: #42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number. PR-URL: #42596 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Fixes: #42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number. PR-URL: #42596 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Fixes: #42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number. PR-URL: #42596 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Fixes: #42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number. PR-URL: #42596 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Fixes: nodejs/node#42164 If the given port number isn't associated with any service name, the `service` resolved from `dns.lookupService` can be a numeric string representing the port number. PR-URL: nodejs/node#42596 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #42164
If the given port number isn't associated with any service name,
the service resolved from dns.lookupService can be a numeric
string representing the port number.