FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http - Updated Doc replaced request.headers with request.getHeaders() by kcak11 · Pull Request #42639 · nodejs/node · GitHub

/ node Public

http - Updated Doc replaced request.headers with request.getHeaders() - #42639

Closed
kcak11 wants to merge 1 commit into
nodejs:masterfrom
kcak11:master
Closed

http - Updated Doc replaced request.headers with request.getHeaders()#42639
kcak11 wants to merge 1 commit into
nodejs:masterfrom
kcak11:master

Conversation

kcak11 commented Apr 7, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 7, 2022

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

VoltrexKeyva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with the commit message being fixed to adhere to the guidelines.

kcak11 changed the title Corrected the documentation to point to request.getHeaders() instead … http - Updated Doc replaced request.headers with request.getHeaders() Apr 7, 2022

kcak11 commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

Will raise another pull-request with correct commit message so that tests pass.

kcak11 closed this Apr 7, 2022

kcak11 commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

Updated pull-request with proper commit message:
#42642

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL