FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix timeout of test-heap-prof.js in riscv devices by ArchFeh · Pull Request #42674 · nodejs/node · GitHub

/ node Public

test: fix timeout of test-heap-prof.js in riscv devices - #42674

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ArchFeh:riscv
Oct 29, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: fix timeout of test-heap-prof.js in riscv devices#42674
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ArchFeh:riscv

Conversation

ArchFeh commented Apr 9, 2022

Copy link
Copy Markdown

In riscv hardware test-heap-prof.js caused timeout in test because of weak performance. So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 9, 2022
test: fix timeout of test-heap-prof.js in riscv devices
1944947 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: nodejs#40152

olof-nord commented Sep 26, 2022

Copy link
Copy Markdown

Hello @ArchFeh, with this PR now approved, are there any open tasks or is it ready to be merged?

ArchFeh commented Sep 27, 2022

Copy link
Copy Markdown
Author

Hello @ArchFeh, with this PR now approved, are there any open tasks or is it ready to be merged?

Hi! I think it is ready to be merged. Thanks!

olof-nord commented Sep 27, 2022

Copy link
Copy Markdown

Hello @jasnell! With this PR approved and ready, what are the outstanding steps required for it to be merged?
I am asking, as there has been no update since a few months.

jasnell commented Oct 2, 2022

Copy link
Copy Markdown
Member

oy, I would have expected this to have landed already :-/ ... I'll start a CI run again just to confirm but this should be able to land now.

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 2, 2022

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/42674
✔  Done loading data for nodejs/node/pull/42674
----------------------------------- PR info ------------------------------------
Title      test: fix timeout of test-heap-prof.js in riscv devices (#42674)
Author     Yu Gu  (@ArchFeh, first-time contributor)
Branch     ArchFeh:riscv -> nodejs:main
Labels     build, test, tools, python, needs-ci
Commits    1
 - test: fix timeout of test-heap-prof.js in riscv devices
Committers 1
 - ArchFeh 
PR-URL: https://github.com/nodejs/node/pull/42674
Fixes: https://github.com/nodejs/node/issues/40152
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42674
Fixes: https://github.com/nodejs/node/issues/40152
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 09 Apr 2022 16:14:48 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42674#pullrequestreview-941119183
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3168192279

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46987/

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47003/

This was referenced Oct 4, 2022
Open
Open
Open
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47522/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2022
nodejs-github-bot merged commit 186745b into nodejs:main Oct 29, 2022

nodejs-github-bot commented Oct 29, 2022

Copy link
Copy Markdown
Collaborator

Landed in 186745b

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
test: fix timeout of test-heap-prof.js in riscv devices
20b0c1a 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
test: fix timeout of test-heap-prof.js in riscv devices
069747b 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <jasnell@gmail.com>
olof-nord mentioned this pull request Nov 27, 2022
Closed
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
test: fix timeout of test-heap-prof.js in riscv devices
59e09f7 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
test: fix timeout of test-heap-prof.js in riscv devices
fe91ac1 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failures in 16.9.1 on Linux/rv64

6 participants

Back | FazBrowse Home | New Git URL