doc: add documentation for inherited methods - #42691
Merged
nodejs-github-bot merged 1 commit intoApr 18, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ShogunPanda
approved these changes
Apr 11, 2022
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
crypt096
reviewed
Apr 11, 2022
crypt096
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42691 ✔ Done loading data for nodejs/node/pull/42691 ----------------------------------- PR info ------------------------------------ Title doc: add documentation for inherited methods (#42691) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:add/inherited-methods -> nodejs:master Labels http, doc Commits 1 - doc: add documentation for inherited methods Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/42691 Reviewed-By: Paolo Insogna ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42691 Reviewed-By: Paolo Insogna -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 11 Apr 2022 08:49:47 GMT ✔ Approvals: 1 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/42691#pullrequestreview-937686744 ✖ This PR needs to wait 37 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2177682550 |
Sorry, something went wrong.
Mesteery
approved these changes
Apr 17, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: nodejs#42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: #42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: #42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: #42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: #42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: #42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: nodejs/node#42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods are inherited from http.OutgoingMessage and
they are already documented as methods of the http.ServerResponse
class. For consistency, document them also as methods of the
http.ClientRequest class.