FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: copyedit http.OutgoingMessage documentation by lpinca · Pull Request #42733 · nodejs/node · GitHub

/ node Public

doc: copyedit http.OutgoingMessage documentation - #42733

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:copyedit/outgoing-message-documentation
Apr 17, 2022
Merged

doc: copyedit http.OutgoingMessage documentation#42733
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:copyedit/outgoing-message-documentation

Conversation

lpinca commented Apr 14, 2022

Copy link
Copy Markdown
Member

Fix nits/typos and simplify some sentences.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 14, 2022
lpinca force-pushed the copyedit/outgoing-message-documentation branch 2 times, most recently from 460a5b0 to 2aa311e Compare April 14, 2022 10:34
Comment thread doc/api/http.md Outdated
Comment on lines 2804 to 2807

lpinca Apr 14, 2022
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've simplified this because a detailed and specific description exists for both ClientRequest#write() and ServerResponse#write().

Fix nits/typos and simplify some sentences.
lpinca force-pushed the copyedit/outgoing-message-documentation branch from 2aa311e to f2785c1 Compare April 14, 2022 10:44

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, good job!

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
nodejs-github-bot merged commit 0699150 into nodejs:master Apr 17, 2022

Copy link
Copy Markdown
Collaborator

Landed in 0699150

lpinca deleted the copyedit/outgoing-message-documentation branch April 17, 2022 19:24
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Fix nits/typos and simplify some sentences.

PR-URL: nodejs#42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
Fix nits/typos and simplify some sentences.

PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
Fix nits/typos and simplify some sentences.

PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Fix nits/typos and simplify some sentences.

PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
Fix nits/typos and simplify some sentences.

PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Fix nits/typos and simplify some sentences.

PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Fix nits/typos and simplify some sentences.

PR-URL: nodejs/node#42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL