worker: add hasRef() to the handle object - #42756
Merged
nodejs-github-bot merged 1 commit intoApr 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Apr 16, 2022
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
force-pushed
the
worker/add-hasRef
branch
from
a28c22b to
3a000eb
Compare
April 16, 2022 13:57
This comment was marked as outdated.
15 tasks
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/workers |
Sorry, something went wrong.
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: nodejs#42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
worker/add-hasRef
branch
from
3a000eb to
abbe313
Compare
April 17, 2022 10:48
This comment was marked as outdated.
This was referenced Apr 18, 2022
addaleax
reviewed
Apr 19, 2022
Comment thread
test/parallel/test-worker-hasref.js
addaleax
approved these changes
Apr 19, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Apr 19, 2022
Copy link
Copy Markdown
Contributor
|
Should this be labelled semver-minor PRs that contain new features and should be released in the next minor version. ? |
Sorry, something went wrong.
16 tasks
This was referenced Apr 21, 2022
RaisinTen
added a commit
to RaisinTen/why-is-node-running
that referenced
this pull request
Apr 24, 2022
At this point, Timeout objects aren't the only handles that have a hasRef() method. nodejs/node#42756 added hasRef() to the Worker handle object that gets reported by async_hooks, so we should consider that too. Fixes: mafintosh#59 Signed-off-by: Darshan Sen <raisinten@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: nodejs#42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
mafintosh
pushed a commit
to mafintosh/why-is-node-running
that referenced
this pull request
Apr 26, 2022
At this point, Timeout objects aren't the only handles that have a hasRef() method. nodejs/node#42756 added hasRef() to the Worker handle object that gets reported by async_hooks, so we should consider that too. Fixes: #59 Signed-off-by: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: #42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Member
I don't think so. The handle object isn't public API. |
Sorry, something went wrong.
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: #42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: #42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: #42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: #42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: nodejs/node#42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.
Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen raisinten@gmail.com