build: improve the format-cpp error message - #42765
Merged
nodejs-github-bot merged 1 commit intoApr 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Trott
reviewed
Apr 17, 2022
Comment thread
.github/workflows/linters.yml
Outdated
RaisinTen
force-pushed
the
build/improve-the-format-cpp-error-message
branch
from
2e12a44 to
d55e95a
Compare
April 17, 2022 14:51
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
build/improve-the-format-cpp-error-message
branch
from
d55e95a to
25846ac
Compare
April 17, 2022 14:57
Trott
approved these changes
Apr 17, 2022
Mesteery
approved these changes
Apr 17, 2022
gengjiawen
approved these changes
Apr 18, 2022
lpinca
approved these changes
Apr 18, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change specifies the target branch name instead of leaving that to
the committer to fill in.
Signed-off-by: Darshan Sen raisinten@gmail.com