FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x backport] test: improve code coverage for streams/duplexify by ErickWendel · Pull Request #42788 · nodejs/node · GitHub

/ node Public

[v16.x backport] test: improve code coverage for streams/duplexify - #42788

Closed
ErickWendel wants to merge 1 commit into
nodejs:v16.x-stagingfrom
ErickWendel:erick/backport-streams-improve-code-coverage
ConversationCommits (1)ChecksFiles changed
Closed

[v16.x backport] test: improve code coverage for streams/duplexify#42788
ErickWendel wants to merge 1 commit into
nodejs:v16.x-stagingfrom
ErickWendel:erick/backport-streams-improve-code-coverage

Conversation

ErickWendel commented Apr 19, 2022

Copy link
Copy Markdown
Member

Backport of #41862

/cc @danielleadams

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 19, 2022
danielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 20, 2022

github-actions Bot commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

nodejs-github-bot commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43591/

nodejs-github-bot commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43599/

nodejs-github-bot commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43603/

This was referenced Apr 21, 2022
Open
Open
Open
ErickWendel changed the base branch from master to v16.x-staging April 23, 2022 15:18
ErickWendel changed the base branch from v16.x-staging to master April 23, 2022 15:18
This was referenced Apr 24, 2022
Open
Open
Open

ErickWendel commented May 24, 2022

Copy link
Copy Markdown
Member Author

is anything missing to approve on this PR?

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
This was referenced May 30, 2022
Open
Open

nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44253/

This was referenced Jun 1, 2022
Open
Open
Open
Open

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44809/

danielleadams commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

@nodejs/collaborators would anyone else be able to review this?

mcollina approved these changes Jun 23, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44819/

danielleadams commented Jun 26, 2022

Copy link
Copy Markdown
Contributor

@ErickWendel I just realized the base of this PR is pointed to main. Can you point it to v16.x-staging and then resolve the merge conflicts? Thank you!

ErickWendel commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

@ErickWendel I just realized the base of this PR is pointed to main. Can you point it to v16.x-staging and then resolve the merge conflicts? Thank you!

Oh. I'm sorry about it. I'll do. This week is being crazy here but I'll trying doing it by the weekend

ErickWendel commented Jul 4, 2022

Copy link
Copy Markdown
Member Author

hey just a heads up. I'm back from vacations so I'll be working on this feature this week o/

ErickWendel force-pushed the erick/backport-streams-improve-code-coverage branch from 7fd01a6 to 9bd0c30 Compare July 5, 2022 20:12
ErickWendel changed the base branch from main to v16.x-staging July 5, 2022 20:12
ErickWendel closed this Jul 5, 2022
ErickWendel deleted the erick/backport-streams-improve-code-coverage branch July 5, 2022 20:15
ErickWendel restored the erick/backport-streams-improve-code-coverage branch July 5, 2022 20:15
ErickWendel reopened this Jul 5, 2022
ErickWendel force-pushed the erick/backport-streams-improve-code-coverage branch from 9bd0c30 to 5bedc83 Compare July 5, 2022 20:25

ErickWendel commented Jul 6, 2022

Copy link
Copy Markdown
Member Author

Ready to go now 🤩

Trott force-pushed the erick/backport-streams-improve-code-coverage branch from 5bedc83 to e8d4384 Compare July 8, 2022 15:59

targos commented Jul 12, 2022

Copy link
Copy Markdown
Member

Thank you @ErickWendel. Landed in 4aa4f7c

targos closed this Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
test: improve code coverage for streams/duplexify
4aa4f7c 
PR-URL: #41862
Backport-PR-URL: #42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
test: improve code coverage for streams/duplexify
147f99c 
PR-URL: #41862
Backport-PR-URL: #42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
test: improve code coverage for streams/duplexify
aae131c 
PR-URL: nodejs/node#41862
Backport-PR-URL: nodejs/node#42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
cclauss cclauss approved these changes
himself65 himself65 approved these changes
benjamingr Awaiting requested review from benjamingr
cjihrig Awaiting requested review from cjihrig
juanarbol Awaiting requested review from juanarbol
+1 more reviewer
danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL