util: fix TypeError when console.log a static property name in class - #42790
Closed
cola119 wants to merge 2 commits into
Closed
util: fix TypeError when console.log a static property name in class#42790cola119 wants to merge 2 commits into
cola119 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Apr 20, 2022
This was referenced Apr 21, 2022
BridgeAR
reviewed
Apr 22, 2022
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is definitely the right spot where to fix it!
Ti improve it further, we could just use String(). That way other types are also handled properly.
Sorry, something went wrong.
Comment thread
lib/internal/util/inspect.js
Outdated
Comment on lines
+582
to
+583
| const name = descriptor.value.name; | ||
| return typeof name === 'symbol' ? SymbolPrototypeToString(name) : name; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| const name = descriptor.value.name; | |
| return typeof name === 'symbol' ? SymbolPrototypeToString(name) : name; | |
| return String(descriptor.value.name); |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Thank you. That makes sense!
Sorry, something went wrong.
21 tasks
This was referenced Apr 24, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BridgeAR
approved these changes
May 19, 2022
This was referenced May 20, 2022
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
31 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
panva
pushed a commit
that referenced
this pull request
Jun 17, 2022
PR-URL: #42790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jun 18, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
PR-URL: #42790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #42773
Constructor name from getConstructorName will be converted to string by template literal (${constructor}) in a subsequent process.
In this case, getConstructorName need to convert symbol to string by Symbol.prototype.toString beforehand since ${Symbol()} throws TypeError (spec).