FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix `parallel/test-dgram-udp6-link-local-address` by aduh95 · Pull Request #42795 · nodejs/node · GitHub

/ node Public

test: fix parallel/test-dgram-udp6-link-local-address - #42795

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
aduh95:fix-dgram-test
Apr 28, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: fix parallel/test-dgram-udp6-link-local-address#42795
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
aduh95:fix-dgram-test

Conversation

aduh95 commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Since #41431 landed, this test is always skipped because family is now an integer, not a string anymore.

Thanks @bl-ue for the report.

Refs: #41431

aduh95 added dont-land-on-v12.x request-ci Add this label to start a Jenkins CI on a PR. labels Apr 20, 2022
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 20, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2022

nodejs-github-bot commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43584/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 20, 2022
github-actions Bot mentioned this pull request Apr 21, 2022
Open
22 tasks

nodejs-github-bot commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43619/

nodejs-github-bot commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43620/

This was referenced Apr 22, 2022
Open
Open
Open
Open
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2022
nodejs-github-bot merged commit 68fb0bf into nodejs:master Apr 28, 2022

nodejs-github-bot commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Landed in 68fb0bf

aduh95 deleted the fix-dgram-test branch April 28, 2022 19:03
targos pushed a commit that referenced this pull request May 2, 2022
test: fix parallel/test-dgram-udp6-link-local-address
3c796f8 
Refs: #41431

PR-URL: #42795
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request May 2, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL