FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: order module linker arguments correctly by SimenB · Pull Request #42797 · nodejs/node · GitHub

/ node Public

docs: order module linker arguments correctly - #42797

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
SimenB:patch-1
Apr 22, 2022
ConversationCommits (1)ChecksFiles changed
Merged

docs: order module linker arguments correctly#42797
aduh95 merged 1 commit into
nodejs:masterfrom
SimenB:patch-1

Conversation

SimenB commented Apr 20, 2022

Copy link
Copy Markdown
Member

nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Apr 20, 2022

SimenB commented Apr 20, 2022

Copy link
Copy Markdown
Member Author

I made this change on GH, and I don't have enough space on my laptop to clone this repo 🙈 Can you fixup the commit message when landing?

aduh95 approved these changes Apr 20, 2022
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That seems to be correct:

node/lib/internal/vm/module.js

Line 312 in 26eed3e

const module = await linker(identifier, this, { assert });

aduh95 commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

/cc @nodejs/vm

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 20, 2022
aduh95 merged commit eeb27c2 into nodejs:master Apr 22, 2022

aduh95 commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Landed in eeb27c2

SimenB deleted the patch-1 branch April 22, 2022 12:24

SimenB commented Apr 22, 2022

Copy link
Copy Markdown
Member Author

Thanks!

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
doc: order vm.Module linker arguments correctly
6999de1 
PR-URL: nodejs#42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
doc: order vm.Module linker arguments correctly
c6c1dc5 
PR-URL: #42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
doc: order vm.Module linker arguments correctly
0958df9 
PR-URL: #42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
doc: order vm.Module linker arguments correctly
e0ed251 
PR-URL: #42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
doc: order vm.Module linker arguments correctly
8783bc9 
PR-URL: #42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
doc: order vm.Module linker arguments correctly
2c447b4 
PR-URL: #42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
doc: order vm.Module linker arguments correctly
8214540 
PR-URL: nodejs/node#42797
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
aduh95 aduh95 approved these changes
marsonya marsonya approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL