FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v8: export cpu_profiler_metadata_size in getHeapCodeStatistics by theanarkh · Pull Request #42818 · nodejs/node · GitHub

/ node Public

v8: export cpu_profiler_metadata_size in getHeapCodeStatistics - #42818

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
theanarkh:export_field_of_heap_code_statistics
Apr 29, 2022
ConversationCommits (1)ChecksFiles changed
Merged

v8: export cpu_profiler_metadata_size in getHeapCodeStatistics#42818
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
theanarkh:export_field_of_heap_code_statistics

Conversation

theanarkh commented Apr 21, 2022

Copy link
Copy Markdown
Contributor
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 21, 2022

theanarkh commented Apr 23, 2022

Copy link
Copy Markdown
Contributor Author

@RaisinTen hello, I noticed that getHeapCodeStatistics is also missing a field, so I add the field to it. Can you help review it ? thanks.

RaisinTen reviewed Apr 24, 2022
View reviewed changes
Comment thread lib/v8.js Outdated
Comment thread doc/api/v8.md Outdated
theanarkh force-pushed the export_field_of_heap_code_statistics branch from 535faee to ad6e8ea Compare April 24, 2022 13:55
RaisinTen approved these changes Apr 24, 2022
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 24, 2022

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Apr 25, 2022
Open
16 tasks

theanarkh commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

@RaisinTen Please help run CI again, Thanks. By the way, whether the CI can only be triggered by member of Node.js ?

This comment was marked as outdated.

Sign in to view

RaisinTen commented Apr 25, 2022

Copy link
Copy Markdown
Member

Sure, done! I think CI can be triggered only by triagers and collaborators.

This comment was marked as outdated.

Sign in to view

theanarkh commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

Sure, done! I think CI can be triggered only by triagers and collaborators.

Thanks, i get it.

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Apr 26, 2022
Open
14 tasks

theanarkh commented Apr 26, 2022

Copy link
Copy Markdown
Contributor Author

@RaisinTen Hi ! Can this PR be merged ?

RaisinTen commented Apr 26, 2022

Copy link
Copy Markdown
Member

Hey, this needs to wait for 7 days before we can merge it, unless someone else also approves it.

theanarkh commented Apr 26, 2022

Copy link
Copy Markdown
Contributor Author

Hey, this needs to wait for 7 days before we can merge it, unless someone else also approves it.

Oh, Thanks.

aduh95 reviewed Apr 26, 2022
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit

Comment thread doc/api/v8.md Outdated
Comment thread lib/v8.js Outdated
Comment thread lib/v8.js Outdated
github-actions Bot mentioned this pull request Apr 27, 2022
Open
11 tasks
theanarkh force-pushed the export_field_of_heap_code_statistics branch 2 times, most recently from d4f964e to 4cdc1b1 Compare April 27, 2022 01:41
aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2022
aduh95 reviewed Apr 27, 2022
View reviewed changes
Comment thread doc/contributing/primordials.md Outdated
theanarkh force-pushed the export_field_of_heap_code_statistics branch from 4cdc1b1 to 462e028 Compare April 27, 2022 10:53

theanarkh commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

@aduh95 Hi, please help review again.

aduh95 commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

/cc @nodejs/v8

github-actions Bot mentioned this pull request Apr 28, 2022
Open
18 tasks

nodejs-github-bot commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43733/

gengjiawen commented Apr 28, 2022

Copy link
Copy Markdown
Member

/cc @nodejs/v8

cc @joyeecheung

github-actions Bot mentioned this pull request Apr 29, 2022
Open
21 tasks
RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2022
nodejs-github-bot merged commit 000a0c8 into nodejs:master Apr 29, 2022

nodejs-github-bot commented Apr 29, 2022

Copy link
Copy Markdown
Collaborator

Landed in 000a0c8

targos pushed a commit that referenced this pull request May 2, 2022
v8: export cpu_profiler_metadata_size in getHeapCodeStatistics
4af0fbd 
PR-URL: #42818
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request May 2, 2022
Merged

juanarbol commented May 30, 2022

Copy link
Copy Markdown
Member

This is not supported in the current V8 version in v16.x

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL