FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: http2.createServer `options` as optional by daeyeon · Pull Request #42832 · nodejs/node · GitHub

/ node Public

doc: http2.createServer options as optional - #42832

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
daeyeon:master.doc-220423.Sat.2c15
Apr 28, 2022
ConversationCommits (1)ChecksFiles changed
Merged

doc: http2.createServer options as optional#42832
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
daeyeon:master.doc-220423.Sat.2c15

Conversation

daeyeon commented Apr 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The method might be designed to explicitly take options. However,
the implementation and many examples already allow the first parameter
of function type. (This is maybe because of Compatibility API.)

node/lib/internal/http2/core.js

Lines 3316 to 3321 in eeb27c2

function createServer(options, handler) {
if (typeof options === 'function') {
handler = options;
options = {};
}
return new Http2Server(options, handler); 

// an example in doc/api/http2.md
const http2 = require('node:http2');
const server = http2.createServer();
server.on('stream', (stream, headers) => { ... });

I'm not sure whether applying the same to http2.createSecureServer is
meaningful. But, seeing https.createServer, the options parameter is
handled as optional.

doc: http2.createServer options as optional
e3dcb46 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

nodejs-github-bot commented Apr 23, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Apr 23, 2022
mcollina approved these changes Apr 23, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ShogunPanda approved these changes Apr 23, 2022
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 24, 2022
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2022
nodejs-github-bot merged commit 489e229 into nodejs:master Apr 28, 2022

nodejs-github-bot commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Landed in 489e229

targos pushed a commit that referenced this pull request May 2, 2022
doc: http2.createServer options as optional
e313dc6 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: #42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request May 2, 2022
Merged
daeyeon deleted the master.doc-220423.Sat.2c15 branch May 25, 2022 03:04
juanarbol pushed a commit that referenced this pull request May 31, 2022
doc: http2.createServer options as optional
56670f0 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: #42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
doc: http2.createServer options as optional
dedd2f0 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: #42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
doc: http2.createServer options as optional
5bdb61b 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: #42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
doc: http2.createServer options as optional
64919a5 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: #42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
doc: http2.createServer options as optional
064835d 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: nodejs/node#42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
lpinca lpinca approved these changes
ronag ronag approved these changes
RafaelGSS RafaelGSS approved these changes
RaisinTen RaisinTen approved these changes
+1 more reviewer
Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL