FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib,src: use Response URL as WebAssembly location by tniessen · Pull Request #42842 · nodejs/node · GitHub

/ node Public

lib,src: use Response URL as WebAssembly location - #42842

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:wasm-web-api-url
Apr 25, 2022
ConversationCommits (1)ChecksFiles changed
Merged

lib,src: use Response URL as WebAssembly location#42842
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:wasm-web-api-url

Conversation

tniessen commented Apr 23, 2022

Copy link
Copy Markdown
Member

As per (non-normative) Section 3 of the WebAssembly Web API spec, if the Response has a url, pass it to V8 so that V8 can construct a conforming WebAssembly location.

Refs: #42701

lib,src: use Response URL as WebAssembly location
b136aea 
As per Section 3 of the WebAssembly Web API spec.
tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2022

nodejs-github-bot commented Apr 23, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 23, 2022
tniessen requested a review from devsnek April 23, 2022 21:32
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2022

This comment was marked as outdated.

Sign in to view
tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 23, 2022

nodejs-github-bot commented Apr 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43656/

This was referenced Apr 24, 2022
Open
Open
tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2022
nodejs-github-bot merged commit 4f9bc41 into nodejs:master Apr 25, 2022

nodejs-github-bot commented Apr 25, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4f9bc41

This was referenced Apr 26, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Apr 28, 2022
lib,src: use Response URL as WebAssembly location
ad82694 
As per Section 3 of the WebAssembly Web API spec.

PR-URL: #42842
Refs: #42701
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request May 2, 2022
Merged

juanarbol commented May 31, 2022

Copy link
Copy Markdown
Member

#42701 is pending to backport

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes
+1 more reviewer
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL