http2: improve tests and docs - #42858
Merged
nodejs-github-bot merged 3 commits intoMay 24, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
daeyeon
force-pushed
the
master.doc-220425.Mon.5754
branch
2 times, most recently
from
870e7a5 to
31dd9d6
Compare
April 25, 2022 06:00
daeyeon
force-pushed
the
master.doc-220425.Mon.5754
branch
from
31dd9d6 to
eda399a
Compare
April 25, 2022 09:06
RafaelGSS
reviewed
Apr 25, 2022
Comment thread
test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js
Outdated
mcollina
approved these changes
Apr 25, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
ShogunPanda
approved these changes
Apr 26, 2022
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
RafaelGSS
approved these changes
Apr 26, 2022
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
daeyeon
force-pushed
the
master.doc-220425.Mon.5754
branch
7 times, most recently
from
4ba9b20 to
f5120d0
Compare
April 28, 2022 00:40
Copy link
Copy Markdown
Member
Author
|
@mcollina @ShogunPanda @RafaelGSS This PR needs a Jenkins CI test, doesn't it? Can someone get it started? Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 15, 2022
Copy link
Copy Markdown
Member
Author
|
Need a rerun of the Jenkins CI. The failures are seemingly unrelated to this PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 19, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
20 tasks
Copy link
Copy Markdown
Member
Author
|
Pls help me re-run the CI.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42858
✔ Done loading data for nodejs/node/pull/42858
----------------------------------- PR info ------------------------------------
Title http2: improve tests and docs (#42858)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch daeyeon:master.doc-220425.Mon.5754 -> nodejs:master
Labels doc, http2, commit-queue-squash
Commits 3
- http2: improve tests and docs
- fix: add client.on('error') and drop :status
- test: update test-http2-server-sessionerror.js
Committers 1
- Daeyeon Jeong
PR-URL: https://github.com/nodejs/node/pull/42858
Reviewed-By: Matteo Collina
Reviewed-By: Paolo Insogna
Reviewed-By: Rafael Gonzaga
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42858
Reviewed-By: Matteo Collina
Reviewed-By: Paolo Insogna
Reviewed-By: Rafael Gonzaga
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - http2: improve tests and docs
⚠ - fix: add client.on('error') and drop :status
⚠ - test: update test-http2-server-sessionerror.js
ℹ This PR was created on Mon, 25 Apr 2022 02:42:16 GMT
✔ Approvals: 3
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42858#pullrequestreview-952377018
✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/42858#pullrequestreview-953188072
✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/42858#pullrequestreview-953315250
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-05-24T07:42:37Z: https://ci.nodejs.org/job/node-test-pull-request/44145/
- Querying data for job/node-test-pull-request/44145/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2377372947
|
Sorry, something went wrong.
mcollina
approved these changes
May 24, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks!! @mcollina @RafaelGSS @ShogunPanda |
Sorry, something went wrong.
This was referenced May 25, 2022
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
This commit documents the event parameters and `http2stream.respond`, and adds some tests to ensure the actual behaviors are aligned with the docs. Testing the 'Http2Server.sessionError' event is added by updating `test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js`. The event seemingly has not been tested so far. `ServerHttp2Session` is exported to validate the `session` event and the `sessionError` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #42858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
This commit documents the event parameters and `http2stream.respond`, and adds some tests to ensure the actual behaviors are aligned with the docs. Testing the 'Http2Server.sessionError' event is added by updating `test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js`. The event seemingly has not been tested so far. `ServerHttp2Session` is exported to validate the `session` event and the `sessionError` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #42858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This commit documents the event parameters and `http2stream.respond`, and adds some tests to ensure the actual behaviors are aligned with the docs. Testing the 'Http2Server.sessionError' event is added by updating `test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js`. The event seemingly has not been tested so far. `ServerHttp2Session` is exported to validate the `session` event and the `sessionError` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #42858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This commit documents the event parameters and `http2stream.respond`, and adds some tests to ensure the actual behaviors are aligned with the docs. Testing the 'Http2Server.sessionError' event is added by updating `test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js`. The event seemingly has not been tested so far. `ServerHttp2Session` is exported to validate the `session` event and the `sessionError` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #42858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This commit documents the event parameters and `http2stream.respond`, and adds some tests to ensure the actual behaviors are aligned with the docs. Testing the 'Http2Server.sessionError' event is added by updating `test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js`. The event seemingly has not been tested so far. `ServerHttp2Session` is exported to validate the `session` event and the `sessionError` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#42858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit documents the event parameters and http2stream.respond, and
adds some tests to ensure the actual behaviors are aligned with the docs.
Testing the Http2Server.sessionError event is added by updating
test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js.
The event seemingly has not been tested so far.
ServerHttp2Session is exported to validate the session event and the
sessionError event.