errors,console: refactor to use ES2020 & ES2021 syntax - #42872
Merged
aduh95 merged 1 commit intoApr 28, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
nit: the logical nullish assignment operator is ES2021 syntax, as it was part of this proposal: https://github.com/tc39/proposal-logical-assignment. Not that it matters a lot, but we could correct the commit message. |
Sorry, something went wrong.
aduh95
approved these changes
Apr 26, 2022
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
approved these changes
Apr 26, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 27, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 29, 2022
targos
pushed a commit
that referenced
this pull request
May 2, 2022
PR-URL: #42872 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42872 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42872 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42872 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42872 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42872 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errors,console: refactor to use ES2020 & ES2021 syntax
Just simplified some codes while I'm reading the newest codes for nodejs. PTAL
ref: #42088. ps: I have found this pr isn't merge yet, and I use rebase to this pr, this is long time ago and I must do something wrong :(…… So I open a new pr for this, sorry for wasting everyone's time