test: fix common.mustNotCall error message - #42917
Merged
aduh95 merged 1 commit intoJun 12, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/cc @nodejs/testing |
Sorry, something went wrong.
ljharb
reviewed
May 10, 2022
ljharb
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM regardless of comment
Sorry, something went wrong.
Comment thread
test/common/index.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Ping @nodejs/testing for reviews. |
Sorry, something went wrong.
targos
approved these changes
Jun 2, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
When using `util.inspect` as a callback, the array index (second argument) is picked up as the `showHidden` param, and the argument array (third argument) as the `depth` param. This fails with a seemingly unrelated error message when the argument array contains a `Symbol`-related property. PR-URL: nodejs#42917 Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
force-pushed
the
fix-mustNotCall-error
branch
from
ae2516c to
5114c46
Compare
June 12, 2022 09:40
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
When using `util.inspect` as a callback, the array index (second argument) is picked up as the `showHidden` param, and the argument array (third argument) as the `depth` param. This fails with a seemingly unrelated error message when the argument array contains a `Symbol`-related property. PR-URL: #42917 Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
When using `util.inspect` as a callback, the array index (second argument) is picked up as the `showHidden` param, and the argument array (third argument) as the `depth` param. This fails with a seemingly unrelated error message when the argument array contains a `Symbol`-related property. PR-URL: #42917 Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
When using `util.inspect` as a callback, the array index (second argument) is picked up as the `showHidden` param, and the argument array (third argument) as the `depth` param. This fails with a seemingly unrelated error message when the argument array contains a `Symbol`-related property. PR-URL: #42917 Reviewed-By: Michaël Zasso <targos@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
When using `util.inspect` as a callback, the array index (second argument) is picked up as the `showHidden` param, and the argument array (third argument) as the `depth` param. This fails with a seemingly unrelated error message when the argument array contains a `Symbol`-related property. PR-URL: nodejs/node#42917 Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using util.inspect as a callback, the array index (second
argument) is picked up as the showHidden param, and the argument
array (third argument) as the depth param. This fails with a seemingly
unrelated error message when the argument array contains a
Symbol-related property.
Before this change, the following error was output:
node:internal/util/inspect:1014 if (recurseTimes > ctx.depth && ctx.depth !== null) { ^ TypeError: Cannot convert a Symbol value to a string at Array.join (<anonymous>) at Array.toString (<anonymous>) at formatRaw (node:internal/util/inspect:1014:20) at formatValue (node:internal/util/inspect:817:10) at inspect (node:internal/util/inspect:347:10) at Array.map (<anonymous>) at Object.mustNotCall [as get] (…) at Array.join (<anonymous>) at Array.toString (<anonymous>) at formatRaw (node:internal/util/inspect:1014:20) Node.js v19.0.0-preWith this change:
node:assert:170 throw err; ^ AssertionError [ERR_ASSERTION]: function should not have been called at … called with arguments: [Function: func] { customProperty: Symbol() }, 'customProperty', [Function: func] { customProperty: Symbol() } at Object.mustNotCall [as get] (…/test/common/index.js:516:12) at Object.<anonymous> (…) at Module._compile (node:internal/modules/cjs/loader:1105:14) at Module._extensions..js (node:internal/modules/cjs/loader:1159:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Module._load (node:internal/modules/cjs/loader:827:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) at node:internal/main/run_main_module:17:47 { generatedMessage: false, code: 'ERR_ASSERTION', actual: [Getter], expected: [Getter], operator: 'fail' } Node.js v19.0.0-pre