lib: use spawn options for timeout in execFile - #42959
Closed
fasttime wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fasttime
marked this pull request as ready for review
May 3, 2022 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout support was added to spawn in v15.13.0 (PR), but execFile has continued to use its own mechanism to implement the timeout functionality, which is now basically replicating the logic added to spawn.
This PR removes the repeated logic from execFile and delegates timeout handling to spawn instead. It does so by forwarding the options timeout and killSignal.
The only visible change I can think of is a different order of parameter validation in execFile, which means a possibly different error message in the case that both timeout and at least another option are passed invalid values. Looking at the other functions in child_process and their tests, and after reading the documentation, it seems to me though that no particular order of parameter validation is being enforced, so I guess this change would have no significant impact.
No functionality was added or removed. All tests are still passing.