FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: TraceEventScope should mark sync duration events by legendecas · Pull Request #42977 · nodejs/node · GitHub

/ node Public

src: TraceEventScope should mark sync duration events - #42977

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:trace-scope
ConversationCommits (1)ChecksFiles changed
Closed

src: TraceEventScope should mark sync duration events#42977
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:trace-scope

Conversation

legendecas commented May 5, 2022

Copy link
Copy Markdown
Member

According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread.

click to see screen shots

Before:

Note that there are no events recorded in the JavaScriptMainThread nor WorkerThread 1.

After:

Environment events like cleanup are correctly grouped under their thread.

legendecas marked this pull request as draft May 5, 2022 15:59
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 5, 2022
legendecas marked this pull request as ready for review May 5, 2022 17:06
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022

This comment was marked as outdated.

Sign in to view
RaisinTen reviewed May 7, 2022
View reviewed changes
Comment thread src/node_internals.h Outdated
RaisinTen approved these changes May 8, 2022
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM apart from one tiny optional nitpick.

Comment thread src/node_contextify.cc
RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 8, 2022

nodejs-github-bot commented May 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43920/

jasnell commented May 8, 2022

Copy link
Copy Markdown
Member

Not sure if this is the correct fix. They were implemented the way they were so that we can trace how long these various methods take to complete so we can better determine if changes introduce performance regressions. That said, they likely aren't broadly used and everything under trace events is still considered experimental and therefore breaking changes are ok.

legendecas commented May 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

The duration events do contain the timestamps on which we can trace how long these methods take to complete, as same as async events. However, synchronous duration events also suggest that these methods are performed in one single thread for a period of time, while async events are not and can be performed intermittently.

@jasnell I'm not sure what you mean by "correct fix". Do you suggest that the methods changed in this PR can be performed in different threads for a given unique id or intermittently?

github-actions Bot mentioned this pull request May 12, 2022
Open
30 tasks

legendecas commented May 12, 2022

Copy link
Copy Markdown
Member Author

@jasnell would you mind elaborating your suggestion here? This PR has opened for 7 days but I'd still like to know your opinions before landing. Thank you.

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2022

nodejs-github-bot commented May 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43970/

This was referenced May 12, 2022
Closed
Open

nodejs-github-bot commented May 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43980/

nodejs-github-bot commented May 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43982/

nodejs-github-bot commented May 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43986/

github-actions Bot mentioned this pull request May 14, 2022
Open
33 tasks

nodejs-github-bot commented May 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44000/

nodejs-github-bot commented May 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44001/

github-actions Bot mentioned this pull request May 15, 2022
Open
28 tasks

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44005/

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44012/

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44013/

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44017/

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44019/

github-actions Bot mentioned this pull request May 16, 2022
Open
25 tasks

nodejs-github-bot commented May 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44025/

legendecas commented May 16, 2022

Copy link
Copy Markdown
Member Author

Landed in 7035186

legendecas closed this May 16, 2022
legendecas added a commit that referenced this pull request May 16, 2022
src: replace TraceEventScope with sync events
7035186 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: #42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
legendecas deleted the trace-scope branch May 16, 2022 14:29
This was referenced May 17, 2022
Open
Open
Open
Open
Open
Open
bengl pushed a commit that referenced this pull request May 30, 2022
src: replace TraceEventScope with sync events
9577878 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: #42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
bengl mentioned this pull request May 31, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
src: replace TraceEventScope with sync events
758c02e 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: #42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
src: replace TraceEventScope with sync events
41e54f2 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: #42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
src: replace TraceEventScope with sync events
6d65809 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: #42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
src: replace TraceEventScope with sync events
438c472 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: #42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
src: replace TraceEventScope with sync events
c3e209b 
According to the chrome trace event format document, works that
are performed on one single thread should be traced with sync
duration events. In this way, these events can be grouped under
one thread and the trace event viewer can estimate the CPU usage
of that thread.

PR-URL: nodejs/node#42977
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL