FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

net: remoteAddress always undefined called before connected by Y1D7NG · Pull Request #43011 · nodejs/node · GitHub

/ node Public

net: remoteAddress always undefined called before connected - #43011

Closed
Y1D7NG wants to merge 1 commit into
nodejs:masterfrom
Y1D7NG:fix-net
ConversationCommits (1)ChecksFiles changed
Closed

net: remoteAddress always undefined called before connected#43011
Y1D7NG wants to merge 1 commit into
nodejs:masterfrom
Y1D7NG:fix-net

Conversation

Y1D7NG commented May 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix #43009

  • when connecting and get remote address, family and port, return this._peername || {} directly.
  • fix remoteFamily is IPvundefined when it doesn't exis, return undefined if it does not exist.

nodejs-github-bot commented May 8, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels May 8, 2022
ShogunPanda approved these changes May 8, 2022
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

ShogunPanda commented May 8, 2022

Copy link
Copy Markdown
Contributor

Can you link that PR so I can take a look tomorrow?

mcollina approved these changes May 8, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Y1D7NG commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

can this be merged?

ShogunPanda commented May 17, 2022

Copy link
Copy Markdown
Contributor

At least two approvals and 48 hours passed. I think we're good to go!

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2022

nodejs-github-bot commented May 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44068/

mcollina approved these changes May 18, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot mentioned this pull request May 19, 2022
Open
27 tasks

nodejs-github-bot commented May 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44086/

nodejs-github-bot commented May 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44087/

ShogunPanda commented May 19, 2022

Copy link
Copy Markdown
Contributor

Landed in b88045f

ShogunPanda pushed a commit that referenced this pull request May 19, 2022
net: remoteAddress always undefined called before connected
b88045f 
PR-URL: #43011
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Y1D7NG deleted the fix-net branch May 19, 2022 14:32
This was referenced May 20, 2022
Open
Open
Open
Open
Open
Open
Open
bengl pushed a commit that referenced this pull request May 30, 2022
net: remoteAddress always undefined called before connected
11c783f 
PR-URL: #43011
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

juanarbol commented May 31, 2022

Copy link
Copy Markdown
Member

This seems to in break v16.x:

make[1]: Leaving directory '/home/juanarbol/GitHub/node/test/node-api/test_worker_terminate/build'                                                       
/usr/bin/python3.10 tools/test.py  --mode=release \                                                                                                      
         \                                                                                                                                               
        --skip-tests= \                                                                                                                                  
        default \                                                                                                                                        
        addons js-native-api node-api                                                                                                                    
=== release test-net-remote-address-port ===                                                                                                             
Path: parallel/test-net-remote-address-port
node:assert:399
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily))

    at Server.<anonymous> (/home/juanarbol/GitHub/node/test/parallel/test-net-remote-address-port.js:38:10)
    at Server.<anonymous> (/home/juanarbol/GitHub/node/test/common/index.js:417:15)
    at Server.emit (node:events:527:28)
    at TCP.onconnection (node:net:1634:8) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

not really sure why, I will label this one as backport-requested in the meantime

bengl mentioned this pull request May 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
lpinca lpinca approved these changes
himself65 himself65 approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

socket.remoteAddress is always undefined once called before connect

8 participants

Back | FazBrowse Home | New Git URL