doc: add document for profile and takeHeapSnapshot command of node inspect - #43018
Closed
cola119 wants to merge 1 commit into
Closed
doc: add document for profile and takeHeapSnapshot command of node inspect#43018cola119 wants to merge 1 commit into
cola119 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
May 9, 2022
Trott
previously requested changes
May 9, 2022
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One question about the unwatch addition....
Sorry, something went wrong.
Comment thread
doc/api/debugger.md
Outdated
cola119
force-pushed
the
add-profile-heap-doc
branch
from
6355f90 to
d7faf6d
Compare
May 9, 2022 21:43
Copy link
Copy Markdown
Member
|
@nodejs/documentation I think this is fine, but it does deviate from our usual docs (using default parameter syntax rather than **Default:**, although this is an unusual case and previous elements in the list already deviate from the standard approach). Since this isn't a programmatic API but an interactive REPL, I think it's fine. What do you think? |
Sorry, something went wrong.
aymen94
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently profile and takeHeapSnapshot command are undocumented in the debugger doc.
node/lib/internal/debugger/inspect_repl.js
Lines 104 to 111 in 0950da1