FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: upgrade npm to 8.10.0 by npm-cli-bot · Pull Request #43061 · nodejs/node · GitHub

/ node Public

deps: upgrade npm to 8.10.0 - #43061

Closed
npm-cli-bot wants to merge 1 commit into
nodejs:masterfrom
npm:npm-8.10.0
ConversationCommits (1)ChecksFiles changed
Closed

deps: upgrade npm to 8.10.0#43061
npm-cli-bot wants to merge 1 commit into
nodejs:masterfrom
npm:npm-8.10.0

Conversation

npm-cli-bot commented May 11, 2022

Copy link
Copy Markdown
Contributor

v8.10.0 (2022-05-11)

Features

Bug Fixes

Dependencies

nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 11, 2022

github-actions Bot commented May 11, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022

This comment was marked as outdated.

Sign in to view
tniessen approved these changes May 11, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2022

nodejs-github-bot commented May 16, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43061
✔  Done loading data for nodejs/node/pull/43061
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.10.0 (#43061)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-cli-bot:npm-8.10.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.10.0
Committers 1
 - npm-cli+bot@github.com 
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 11 May 2022 17:17:21 GMT
   ✔  Approvals: 4
   ✔  - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411
   ℹ  This PR is being fast-tracked
   ⚠  GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-05-11T18:16:38Z: https://ci.nodejs.org/job/node-test-pull-request/43962/
- Querying data for job/node-test-pull-request/43962/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2334046116

sepehrst commented May 16, 2022

Copy link
Copy Markdown

This needs a rebase. As well as almost every other non doc: PR which are not based on top of 347000c (prior to the landing time of #43085 @ May 15, 2022, 5:05 AM UTC)

ruyadorno commented May 17, 2022

Copy link
Copy Markdown
Member

Thanks @wraithgar!

wraithgar commented May 17, 2022

Copy link
Copy Markdown
Contributor

I clicked the button in the github ui so it did a merge commit, not a rebase. idk if that matters here but now you know.

ruyadorno commented May 17, 2022

Copy link
Copy Markdown
Member

I'm not sure this will work 🤔 I'll go ahead and rebase the commit to be sure 😊

ruyadorno added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2022

This comment was marked as outdated.

Sign in to view
tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 17, 2022
github-actions Bot mentioned this pull request May 18, 2022
Open
28 tasks

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented May 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44067/

ruyadorno added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 18, 2022

nodejs-github-bot commented May 18, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43061
✔  Done loading data for nodejs/node/pull/43061
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.10.0 (#43061)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-cli-bot:npm-8.10.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.10.0
Committers 1
 - Ruy Adorno 
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - deps: upgrade npm to 8.10.0
   ℹ  This PR was created on Wed, 11 May 2022 17:17:21 GMT
   ✔  Approvals: 4
   ✔  - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411
   ℹ  This PR is being fast-tracked
   ⚠  GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-05-18T14:21:53Z: https://ci.nodejs.org/job/node-test-pull-request/44067/
- Querying data for job/node-test-pull-request/44067/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2346657102

lpinca commented May 18, 2022

Copy link
Copy Markdown
Member

Landed in 06dd8c3.

lpinca pushed a commit that referenced this pull request May 18, 2022
deps: upgrade npm to 8.10.0
06dd8c3 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
lpinca closed this May 18, 2022
This was referenced May 19, 2022
Open
Open
Open
Open
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request May 27, 2022
deps: upgrade npm to 8.10.0
d0b53c0 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
bengl pushed a commit that referenced this pull request May 30, 2022
deps: upgrade npm to 8.10.0
d42de13 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ruyadorno mentioned this pull request May 30, 2022
Merged
bengl mentioned this pull request May 31, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
deps: upgrade npm to 8.10.0
e69fc6f 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol mentioned this pull request May 31, 2022
Closed
juanarbol pushed a commit that referenced this pull request Jun 1, 2022
deps: upgrade npm to 8.10.0
68572bd 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol mentioned this pull request Jun 1, 2022
Merged
This was referenced Jan 28, 2025
Closed
Closed
wraithgar deleted the npm-8.10.0 branch June 26, 2025 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ruyadorno ruyadorno approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL