| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
There was a problem hiding this comment.
Is there a reason to refactor this to ESM?
Sorry, something went wrong.
@aduh95 Thanks for the review. I see the newly added file on tools directory is all ESM module, so I think we could also refactor other commonjs format file to esm module format to make:
|
Sorry, something went wrong.
|
FYI ESM means 'ECMAScript module', so "esm module" is redundant. I'd suggest using refactor … to ESM or refactor … to ESM syntax instead. Maybe instead of rl.line, we should use for await(const line of rl), using to our advantage top-level await to improve the script readability would be a very good argument for switching to ESM. |
Sorry, something went wrong.
Good suggestion. I have refactored rl.on('line' to for await(const line of rl). please take another look. the pr title is also changed to refactor … to ESM |
Sorry, something went wrong.
PR-URL: #43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
| Back | FazBrowse Home | New Git URL |
Motivation