meta: add mailmap entry for npm team - #43143
Merged
nodejs-github-bot merged 1 commit intoMay 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
May 18, 2022
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
Trott
approved these changes
May 18, 2022
Copy link
Copy Markdown
Member
Author
|
I'll move the second commit to a different PR to keep things clean. |
Sorry, something went wrong.
lpinca
force-pushed
the
add/mailmap-entry-for-npm-teamp
branch
from
d9c276b to
96bcfec
Compare
May 18, 2022 19:11
Trott
approved these changes
May 18, 2022
tniessen
approved these changes
May 18, 2022
VoltrexKeyva
approved these changes
May 19, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43143 ✔ Done loading data for nodejs/node/pull/43143 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for npm team (#43143) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:add/mailmap-entry-for-npm-teamp -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: add mailmap entry for npm team Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/43143 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43143 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 18 May 2022 17:54:33 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43143#pullrequestreview-977491383 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43143#pullrequestreview-977528970 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43143#pullrequestreview-978043935 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2352029089 |
Sorry, something went wrong.
Trott
requested changes
May 19, 2022
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The entry in this PR will have no affect. It needs to be changed.
Sorry, something went wrong.
Comment thread
.mailmap
Outdated
lpinca
force-pushed
the
add/mailmap-entry-for-npm-teamp
branch
from
b8a2975 to
83a4524
Compare
May 19, 2022 13:48
Trott
approved these changes
May 19, 2022
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled.