FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document `signal` option for `EventTarget#addEventListener` by aduh95 · Pull Request #43170 · nodejs/node · GitHub

/ node Public

doc: document signal option for EventTarget#addEventListener - #43170

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
aduh95:addEventListener-signal-option-doc
May 25, 2022
ConversationCommits (1)ChecksFiles changed
Merged

doc: document signal option for EventTarget#addEventListener#43170
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
aduh95:addEventListener-signal-option-doc

Conversation

aduh95 commented May 21, 2022

Copy link
Copy Markdown
Contributor

Refs: #36258

nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels May 21, 2022
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 21, 2022
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2022

nodejs-github-bot commented May 25, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43170
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/2385162248

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 25, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2022
nodejs-github-bot merged commit a346572 into nodejs:master May 25, 2022

nodejs-github-bot commented May 25, 2022

Copy link
Copy Markdown
Collaborator

Landed in a346572

aduh95 deleted the addEventListener-signal-option-doc branch May 25, 2022 15:45
bengl pushed a commit that referenced this pull request May 30, 2022
doc: document signal option for EventTarget#addEventListener
76b4680 
Refs: #36258

PR-URL: #43170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bengl mentioned this pull request May 31, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
doc: document signal option for EventTarget#addEventListener
1d1481c 
Refs: #36258

PR-URL: #43170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
doc: document signal option for EventTarget#addEventListener
4dd4f6c 
Refs: #36258

PR-URL: #43170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
doc: document signal option for EventTarget#addEventListener
1867462 
Refs: #36258

PR-URL: #43170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
doc: document signal option for EventTarget#addEventListener
d86d4d7 
Refs: nodejs/node#36258

PR-URL: nodejs/node#43170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
shisama shisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL