fix address already in use in test-domain-dep0097 - #43199
Closed
everett1992 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lpinca
approved these changes
May 24, 2022
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port. This commit changes to bind to a random free port
JungMinu
approved these changes
May 25, 2022
tniessen
approved these changes
May 25, 2022
marsonya
approved these changes
May 25, 2022
This comment was marked as outdated.
This was referenced May 28, 2022
This comment was marked as outdated.
18 tasks
This comment was marked as outdated.
16 tasks
mhdawson
approved these changes
May 31, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
17 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 2, 2022
mhdawson
pushed a commit
that referenced
this pull request
Jun 13, 2022
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port. This commit changes to bind to a random free port PR-URL: #43199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 14, 2022
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port. This commit changes to bind to a random free port PR-URL: #43199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port. This commit changes to bind to a random free port PR-URL: #43199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port. This commit changes to bind to a random free port PR-URL: #43199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port. This commit changes to bind to a random free port PR-URL: nodejs/node#43199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-domain-dep0097.js was sporadically failing because it is a parallel test and uses opens a default inspector port.
This commit changes to bind to a random free port