FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix json utils escapes for U+000B by legendecas · Pull Request #43206 · nodejs/node · GitHub

/ node Public

src: fix json utils escapes for U+000B - #43206

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:issue-43193
ConversationCommits (1)ChecksFiles changed
Closed

src: fix json utils escapes for U+000B#43206
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:issue-43193

Conversation

legendecas commented May 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

According to the https://www.ecma-international.org/wp-content/uploads/ECMA-404_2nd_edition_december_2017.pdf section 9 String, there are only the following two-character escape sequences:

  • \" represents the quotation mark character (U+0022).
  • \\ represents the reverse solidus character (U+005C).
  • \/ represents the solidus character (U+002F).
  • \b represents the backspace character (U+0008).
  • \f represents the form feed character (U+000C).
  • \n represents the line feed character (U+000A).
  • \r represents the carriage return character (U+000D).
  • \t represents the character tabulation character (U+0009).

\v is not one of them. So it should be escaped with hexadecimal sequence.

Fixes: #43193

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 25, 2022
legendecas marked this pull request as ready for review May 25, 2022 15:37
legendecas requested a review from addaleax May 26, 2022 14:58
mhdawson approved these changes May 27, 2022
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2022

nodejs-github-bot commented May 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44196/

This was referenced May 28, 2022
Open
Open
Open

nodejs-github-bot commented May 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44243/

github-actions Bot mentioned this pull request May 31, 2022
Open
16 tasks

nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44250/

github-actions Bot mentioned this pull request Jun 1, 2022
Open
17 tasks

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44271/

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44297/

github-actions Bot mentioned this pull request Jun 2, 2022
Open
19 tasks

nodejs-github-bot commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44319/

This was referenced Jun 3, 2022
Open
Open

nodejs-github-bot commented Jun 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44371/

nodejs-github-bot commented Jun 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44382/

nodejs-github-bot commented Jun 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44384/

legendecas added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 10, 2022

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44420/

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44424/

nodejs-github-bot commented Jun 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44464/

nodejs-github-bot commented Jun 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44468/

github-actions Bot mentioned this pull request Jun 13, 2022
Open
15 tasks

nodejs-github-bot commented Jun 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44480/

nodejs-github-bot commented Jun 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44505/

github-actions Bot mentioned this pull request Jun 14, 2022
Open
16 tasks
legendecas added a commit that referenced this pull request Jun 14, 2022
src: fix json utils escapes for U+000B
486dcd7 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

legendecas commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

Landed in 486dcd7

legendecas closed this Jun 14, 2022
legendecas deleted the issue-43193 branch June 14, 2022 03:56
danielleadams pushed a commit that referenced this pull request Jun 14, 2022
src: fix json utils escapes for U+000B
a056840 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jun 14, 2022
Merged
github-actions Bot mentioned this pull request Jun 15, 2022
Open
17 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
src: fix json utils escapes for U+000B
fbe35e3 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
src: fix json utils escapes for U+000B
094d5fc 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
jonaldinger mentioned this pull request Aug 18, 2022
Closed
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
src: fix json utils escapes for U+000B
e2a80f9 
PR-URL: nodejs/node#43206
Fixes: nodejs/node#43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
JungMinu JungMinu approved these changes
richardlau richardlau approved these changes
addaleax Awaiting requested review from addaleax
+2 more reviewers
mhdawson mhdawson approved these changes
tony-go tony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSON Parse error in internal/process/report?

7 participants

Back | FazBrowse Home | New Git URL