FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x backport] tools: update V8 gypfiles for 9.6 by RaisinTen · Pull Request #43247 · nodejs/node · GitHub

/ node Public

[v16.x backport] tools: update V8 gypfiles for 9.6 - #43247

Closed
RaisinTen wants to merge 2 commits into
nodejs:v16.x-stagingfrom
RaisinTen:backport-cross-compile-fix-to-v16.x
ConversationCommits (2)ChecksFiles changed
Closed

[v16.x backport] tools: update V8 gypfiles for 9.6#43247
RaisinTen wants to merge 2 commits into
nodejs:v16.x-stagingfrom
RaisinTen:backport-cross-compile-fix-to-v16.x

Conversation

RaisinTen commented May 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This is a clean cherry-pick of 6ac1ccc and 4d2d44f. With this change, it
is possible to cross-compile from x86_64 to ARM64 on macOS.

Fixes: #40350

cc @targos

Original commit messages:

tools: update V8 gypfiles for 9.6
f101e43 
PR-URL: nodejs#40488
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot commented May 30, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v16.x v8 engine Issues and PRs related to the V8 dependency. labels May 30, 2022

This comment was marked as outdated.

Sign in to view
RaisinTen mentioned this pull request May 30, 2022
Closed

gengjiawen commented May 30, 2022

Copy link
Copy Markdown
Member

Should we add this to github actions ?

targos commented May 30, 2022

Copy link
Copy Markdown
Member

Should we add this to github actions ?

@gengjiawen what do you mean?

gengjiawen commented May 30, 2022

Copy link
Copy Markdown
Member

Should we add this to github actions ?

@gengjiawen what do you mean?

cross-compile check on macOS in github actions.

RaisinTen commented May 30, 2022

Copy link
Copy Markdown
Member Author

I think we could do that in a separate PR.

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 30, 2022

targos commented May 30, 2022

Copy link
Copy Markdown
Member

macOS compilation is very slow in GitHub actions. I'd prefer if we tried to do it on our own machines

tools: disable trap handler for Windows cross-compiler
2e56e92 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs#40488
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

RaisinTen commented May 30, 2022

Copy link
Copy Markdown
Member Author

The win-vs2019-arm64 build was failing with the same error as reported in #40488 (comment):

C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\handler-outside-simulator.cc(33,56): error C2290: C++ 'asm' syntax ignored. Use __asm. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]

so I also cherry-picked 4d2d44f.

nodejs-github-bot commented May 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44236/

juanarbol pushed a commit that referenced this pull request May 31, 2022
tools: update V8 gypfiles for 9.6
776d11a 
PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
tools: disable trap handler for Windows cross-compiler
520e5d9 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request Jun 1, 2022
tools: update V8 gypfiles for 9.6
47cdddf 
PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request Jun 1, 2022
tools: disable trap handler for Windows cross-compiler
feac215 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

juanarbol commented Jun 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you!!!

Landed in 447f9a0...feac215

juanarbol closed this Jun 1, 2022
RaisinTen deleted the backport-cross-compile-fix-to-v16.x branch June 1, 2022 04:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
BethGriggs BethGriggs approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL