inspector: add missing initialization - #43254
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <mdawson@devrus.com>
RaisinTen
approved these changes
May 31, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
17 tasks
JungMinu
approved these changes
Jun 1, 2022
lpinca
approved these changes
Jun 1, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 2, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
added a commit
that referenced
this pull request
Jun 14, 2022
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43254 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jun 15, 2022
danielleadams
pushed a commit
that referenced
this pull request
Jun 16, 2022
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43254 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43254 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43254 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#43254 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing initialization reported by coverity. With
proper usage it looks like it will be initialized but
still good to have it initialized to a known state in
case that changes or invalide usage.
The method used to create object ids newObjectId() starts
at 1 so initializing to 0 should be safe and what we get
now when compiled in a way that auto initializes (for example
debug)
Signed-off-by: Michael Dawson mdawson@devrus.com