FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update undici to 5.4.0 by nodejs-github-bot · Pull Request #43262 · nodejs/node · GitHub

/ node Public

deps: update undici to 5.4.0 - #43262

Merged
nodejs-github-bot merged 1 commit into
masterfrom
actions/tools-update-undici
Jun 1, 2022
ConversationCommits (1)ChecksFiles changed
Merged

deps: update undici to 5.4.0#43262
nodejs-github-bot merged 1 commit into
masterfrom
actions/tools-update-undici

Conversation

nodejs-github-bot commented May 31, 2022 •
edited by mcollina
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 5.4.0.

Notable Change: we dropped the limits on the forbidden headers in fetch() as a spec deviation for server-side implementations.

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 31, 2022

tniessen commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

panva commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

@nodejs/undici

Trott commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

I think I've seen this in other updates. After the authors or eslint updates are merged, I always delete the branch to avoid this. Notice that there are two commits here. So that's almost surely what happened here too.

Trott commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

I think I've seen this in other updates. After the authors or eslint updates are merged, I always delete the branch to avoid this. Notice that there are two commits here. So that's almost surely what happened here too.

Might be a good idea for someone to change all the update GitHub jobs to delete the existing branch before creating the pull request.

Trott force-pushed the actions/tools-update-undici branch from c33f2de to 38ecb99 Compare May 31, 2022 12:55

Trott commented May 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I fixed the branch with the following commands:

git checkout actions/tools-update-undici
git reset --hard upstream/actions/tools-update-undici
git rebase -i upstream/master
git push --force-with-lease upstream actions/tools-update-undici

Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels May 31, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2022

This comment was marked as outdated.

Sign in to view
mcollina approved these changes May 31, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44256/

mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label May 31, 2022
mcollina mentioned this pull request May 31, 2022
Merged
mcollina added the fast-track PRs that do not need to wait for 48 hours to land. label May 31, 2022

github-actions Bot commented May 31, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

github-actions Bot mentioned this pull request Jun 1, 2022
Open
17 tasks

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44276/

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44293/

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44302/

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44304/

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 1, 2022
mcollina added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 1, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2022
nodejs-github-bot merged commit 921ef9b into master Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

Landed in 921ef9b

aduh95 deleted the actions/tools-update-undici branch June 1, 2022 21:52
bengl pushed a commit that referenced this pull request Jun 1, 2022
deps: update undici to 5.4.0
dc3b91f 
PR-URL: #43262
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
bengl added a commit that referenced this pull request Jun 1, 2022
2022-06-01, Version 18.3.0 (Current)
49362ef 
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) #43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
github-actions Bot mentioned this pull request Jun 2, 2022
Open
19 tasks
bengl added a commit that referenced this pull request Jun 2, 2022
2022-06-01, Version 18.3.0 (Current)
55f56ef 
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) #43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
This was referenced Jun 3, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
deps: update undici to 5.4.0
4db4d53 
PR-URL: #43262
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams added a commit that referenced this pull request Jun 27, 2022
2022-06-28, Version 16.15.2 'Gallium' (LTS)
39950b4 
Notable changes:

* deps:
  * update undici to 5.4.0 (Node.js GitHub Bot) #43262
* doc:
  * add LiviaMedeiros to collaborators (LiviaMedeiros) #43039
  * add @kuriyosh to collaborators (Yoshiki Kurihara) #42824
  * add RafaelGSS to collaborators (RafaelGSS) #42718
  * add @meixg to collaborators (Xuguang Mei) #42576
targos pushed a commit that referenced this pull request Jul 12, 2022
deps: update undici to 5.4.0
bc6a368 
PR-URL: #43262
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
deps: update undici to 5.4.0
0ff0094 
PR-URL: #43262
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
deps: update undici to 5.4.0
d216dd7 
PR-URL: nodejs/node#43262
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
coderabbitai Bot mentioned this pull request Jul 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
panva panva approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL