tools: use hashes instead of tags for external actions - #43284
Merged
aduh95 merged 2 commits intoJun 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment)
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
reviewed
Jun 1, 2022
Comment thread
.github/workflows/coverage-linux.yml
Outdated
targos
reviewed
Jun 1, 2022
Comment thread
.github/workflows/coverage-windows.yml
Outdated
Copy link
Copy Markdown
Member
Isn't this also valid for actions/* actions? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
actions/* are controlled by GitHub, who controls the runners and the secrets anyway, so I don't think it's a risk to trust them with tags. |
Sorry, something went wrong.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
targos
approved these changes
Jun 2, 2022
lpinca
approved these changes
Jun 3, 2022
Copy link
Copy Markdown
Contributor
|
glad that we're doing this :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43284 ✔ Done loading data for nodejs/node/pull/43284 ----------------------------------- PR info ------------------------------------ Title tools: use hashes instead of tags for external actions (#43284) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:no-tags-for-external-actions -> nodejs:master Labels meta, author ready, commit-queue-squash Commits 2 - tools: use hashes instead of tags for external actions - Apply suggestions from code review Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/43284 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43284 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 01 Jun 2022 15:21:17 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/43284#pullrequestreview-993164651 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43284#pullrequestreview-995322504 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2444122549 |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: nodejs/node#43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using tags is a security risk, as they can be updated to point to
anything else.
Refs: nodejs/corepack#117 (comment)