FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add `avoid-prototype-pollution` lint rule by aduh95 · Pull Request #43308 · nodejs/node · GitHub

/ node Public

tools: add avoid-prototype-pollution lint rule - #43308

Merged
nodejs-github-bot merged 3 commits into
nodejs:masterfrom
aduh95:avoid-prototype-pollution-lint
Jun 11, 2022
ConversationCommits (3)ChecksFiles changed
Merged

tools: add avoid-prototype-pollution lint rule#43308
nodejs-github-bot merged 3 commits into
nodejs:masterfrom
aduh95:avoid-prototype-pollution-lint

Conversation

aduh95 commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

To ensure the work in #43270 doesn't get reverted.

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 3, 2022

ljharb commented Jun 3, 2022

Copy link
Copy Markdown
Member

LGTM!

Trott reviewed Jun 4, 2022
View reviewed changes
Comment thread lib/.eslintrc.yaml Outdated
node-core/lowercase-name-for-primitive: error
node-core/non-ascii-character: error
node-core/no-array-destructuring: error
node-core/avoid-prototype-pollution: error

Trott Jun 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Non-blocking nit: The other rules are all in alphabetical order, so maybe consider moving this and/or renaming it? (no-pollutable-prototypes or something like that?)

aduh95 commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

@nodejs/linting can this get some reviews please?

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2022

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44428/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 10, 2022

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44433/

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44434/

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44435/

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44439/

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44440/

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 11, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022
nodejs-github-bot merged commit 93728c6 into nodejs:master Jun 11, 2022

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in 93728c6

aduh95 deleted the avoid-prototype-pollution-lint branch June 11, 2022 13:51
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
tools: add avoid-prototype-pollution lint rule
3d4063f 
PR-URL: #43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Jun 11, 2022
Merged
github-actions Bot mentioned this pull request Jun 13, 2022
Open
15 tasks
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
tools: add avoid-prototype-pollution lint rule
cf8a115 
PR-URL: #43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
github-actions Bot mentioned this pull request Jun 14, 2022
Open
16 tasks

targos commented Jul 31, 2022

Copy link
Copy Markdown
Member

@aduh95 would you like to backport to v16.x?
The commit lands cleanly but introduces errors with the new rule on some files.
#43393 and #43391 could also be backported with it.

targos commented Jul 31, 2022

Copy link
Copy Markdown
Member

Also blocks #43475

aduh95 mentioned this pull request Aug 1, 2022
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Aug 1, 2022
tools: add avoid-prototype-pollution lint rule
0f489bc 
PR-URL: nodejs#43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2022
tools: add avoid-prototype-pollution lint rule
1d09407 
PR-URL: #43308
Backport-PR-URL: #44081
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
tools: add avoid-prototype-pollution lint rule
e404223 
PR-URL: nodejs/node#43308
Backport-PR-URL: nodejs/node#44081
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL