Update addons.markdown - #4331
Conversation
Sorry, something went wrong.
update link from github.com/rvagg to github.com/nodejs
|
LGTM |
Sorry, something went wrong.
Update link from github.com/rvagg to github.com/nodejs PR-URL: #4331 Reviewed-By: James M Snell <jasnell@gmail.com>
|
@jasnell FYI: this is present in docs for the current release as well. (I saw the lts-watch tag, and want to make sure it will update the link in every relevant release.) |
Sorry, something went wrong.
|
Yep. Will definitely make sure it lands in v4. Will need someone to pull it into v5 also |
Sorry, something went wrong.
Update link from github.com/rvagg to github.com/nodejs PR-URL: nodejs#4331 Reviewed-By: James M Snell <jasnell@gmail.com>
Update link from github.com/rvagg to github.com/nodejs PR-URL: #4331 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Thanks for this @nicholaswyoung, I believe this is your first commit to core and even though the change is trivial we appreciate the attention to detail. Welcome on board, we hope you stick around and can find other ways to contribute. |
Sorry, something went wrong.
|
@rvagg It is. I don't know why I waited this long to send a patch, but with the warm welcome that I received—I don't think it will be my last! |
Sorry, something went wrong.
Update link from github.com/rvagg to github.com/nodejs PR-URL: nodejs#4331 Reviewed-By: James M Snell <jasnell@gmail.com>
Update link from github.com/rvagg to github.com/nodejs PR-URL: #4331 Reviewed-By: James M Snell <jasnell@gmail.com>
Update link from github.com/rvagg to github.com/nodejs PR-URL: nodejs#4331 Reviewed-By: James M Snell <jasnell@gmail.com>
update link from github.com/rvagg to github.com/nodejs, to remove stale URI.